[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled You probably want Gavin to review the code; +1 from a UI standpoint from me. If there's a tryserver build attached, I can help test and see if there are any edge cases, since I can't read the code changes that

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
Refining title, Ctrl-Q is present on Mac, Cmd-Q on OS X. As far as I know, Ctrl-Q doesn't work on Windows, so it's not a problem there. Alt-F4 closes a window on Windows, so it's not going to be accidentally triggered when closing a tab (Ctrl-W) — so we don't need to handle that in any way (unless

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
This is especially noticable on a Mac since ⌘Q and ⌘W are right next to each other, but in general it violates the principle of least surprise: We currently ask when you quit your browser whether that's what you wanted to do, and give you an option to "never ask again". However, when turning on S

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
OK, I guess I changed my mind slightly here after living with it for a while — I now think we should ask when trying to quit using the keyboard (still with the "Do not ask me again" shortcut, but not when quitting using the menu or (on Windows) the close button. -- You received this bug notificat

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
Should probably be a softblocker if so. (Adding d? to get driver input, let me know if this isn't the way to go about this :) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
To reduce confusion (people on IRC said it was still a bit unclear), here's what we're proposing: * On Mac & Linux, since they have the Cmd-Q shortcut to quit the browser, we want to warn users that they're about to close all their tabs (or quit) when they do it using the keyboard shortcut *only*.