[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Comment on attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws Checked and looks good. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to Amy Lee [:amylee] UX from comment #65) > Comment on attachment 9021147 > Bug 550559 - also show close warnings when session restore is active, r?jaws > > Hi, > > I installed the mac version and I don't see an update to about:preferences > under the Tabs section (“Warn you when quitt

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Created attachment 8995330 Preferences - Close Tab Warning.png Spec for Restore Previous Session Setting in Preferences -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > (In reply to Meridel from comment #46) > > Prefs copy looks good and hasn't changed from what we have currently. > > > > Edits to close warning dialogue: > > -Numbers less than ten should be spelled out. So if the user is clos

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
I've attached a spec for Preferences when Session Restore is Enabled and Disabled. The warning will not show up by default if Session Restore is enabled but I've added a pref that allows users to turn the warning message on when Session Restore is enabled if desired. NI Meridel to review the copy.

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Created attachment 8999195 Preferences - Close Tab Warning.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Stat

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Comment on attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws Hi, I installed the mac version and I don't see an update to about:preferences under the Tabs section (“Warn you when quitting and closing multiple tabs”) -- You received this bug notifica

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #50) > (In reply to Amy Lee [:amylee] UX from comment #49) > > (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > > > Second, users who are used to the current behavior with session restore > > > enabled (esp. on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (he/him) from comment #68) > (In reply to :Gijs (he/him) from comment #67) > > (In reply to Amy Lee [:amylee] UX from comment #65) > > > Comment on attachment 9021147 > > > Bug 550559 - also show close warnings when session restore is active, > > > r?jaws > > > > > > Hi, > > >

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (he/him) from comment #59) > Amy, this bug is still assigned to you - is there more that needs to happen > design-wise or is this ready to be implemented? The design is ready to be implemented. Can you please reassign the bug to someone that implement? -- You received this bug

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Great! Thanks Meridel. Can we reassign this bug to someone that can implement the changes? Currently this bug is assigned to me. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Ti

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
After going through the thread and related bugs, it seems to make sense to have a confirmation dialogue when quitting the browser. Also it looks like a confirmation dialogue does appear in Windows/Linux when "closing" multiple tabs and not when "quitting" which is confusing. There is no confirmatio

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Created attachment 8989553 Linux_Windows_Close.png Reference for above comment -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open"

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
To clarify this confirmation should exist when quitting the browser in all menus (not only when using shortcut keys) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn