Re: PATCH: simplify regular expressions

2018-12-11 Thread Jacob Bachmeyer
Pedro Alves wrote: On 12/10/2018 10:30 PM, Jacob Bachmeyer wrote: Should DejaGnu eventually support GDB's MI mode, possibly in another module? Would this be for GDB's own testing, or for something else? The intent was (future) use of GDB as a tool within DejaGnu as part of tests

Re: PATCH: simplify regular expressions

2018-12-11 Thread Ben Elliston
On Tue, Dec 11, 2018 at 03:25:06PM +, Pedro Alves wrote: > Would this be for GDB's own testing, or for something else? No, for controlling GDB from DejaGnu. Consider a version of gdb_comm_delete_breakpoints that interacts with the controlled GDB process using MI instead of matching string out

Re: PATCH: simplify regular expressions

2018-12-11 Thread Pedro Alves
On 12/10/2018 10:30 PM, Jacob Bachmeyer wrote: > Should DejaGnu eventually support GDB's MI mode, possibly in another module? Would this be for GDB's own testing, or for something else? GDB already has MI testcases driven by dejagnu. Most live under gdb/testsuite/gdb.mi/ https://sourceware.or

Re: PATCH: simplify regular expressions

2018-12-11 Thread Rob Savoye
On 12/11/18 2:55 AM, Ben Elliston wrote: > On Mon, Dec 10, 2018 at 04:30:49PM -0600, Jacob Bachmeyer wrote: > >> GDB has changed somewhat over the years; are the strings those >> modules seek still valid or do we need to accept both "old" and >> "new" message sets? Should DejaGnu eventually suppo

Re: PATCH: simplify regular expressions

2018-12-11 Thread Ben Elliston
On Mon, Dec 10, 2018 at 04:30:49PM -0600, Jacob Bachmeyer wrote: > GDB has changed somewhat over the years; are the strings those > modules seek still valid or do we need to accept both "old" and > "new" message sets? Should DejaGnu eventually support GDB's MI > mode, possibly in another module?

Re: PATCH: simplify regular expressions

2018-12-10 Thread Jacob Bachmeyer
Ben Elliston wrote: This patch is further to: http://lists.gnu.org/archive/html/dejagnu/2018-12/msg00042.html I would be grateful for a careful review from someone. Thanks, Ben 2018-12-10 Ben Elliston * config/gdb-comm.exp, config/gdb_stub.exp, config/vxworks.exp, lib/dg.ex

Re: PATCH: simplify regular expressions

2018-12-10 Thread Andreas Schwab
On Dez 10 2018, Ben Elliston wrote: > diff --git a/config/gdb-comm.exp b/config/gdb-comm.exp > index c9ef574..1e57eac 100644 > --- a/config/gdb-comm.exp > +++ b/config/gdb-comm.exp > @@ -86,7 +86,7 @@ proc gdb_comm_file_cmd { arg } { > verbose "\t\tKilling previous program being debugge

PATCH: simplify regular expressions

2018-12-10 Thread Ben Elliston
This patch is further to: http://lists.gnu.org/archive/html/dejagnu/2018-12/msg00042.html I would be grateful for a careful review from someone. Thanks, Ben 2018-12-10 Ben Elliston * config/gdb-comm.exp, config/gdb_stub.exp, config/vxworks.exp, lib/dg.exp, lib/framework.exp,