Re: PATCH: remove redundant methods in dejagnu.h

2018-12-03 Thread Rob Savoye
On 12/3/18 4:56 PM, Jacob Bachmeyer wrote: > What revision of C++ added those runtime type conversions?  Is it > plausible that any projects out there might be using an older C++ > version?  Could there be a compiler out there that does not do those > conversions on function calls even though it s

Re: PATCH: remove redundant methods in dejagnu.h

2018-12-03 Thread Ben Elliston
On Mon, Dec 03, 2018 at 05:56:19PM -0600, Jacob Bachmeyer wrote: > What revision of C++ added those runtime type conversions? The C++ standard string class has had a const char * constructor for as long as I can remember. Ben signature.asc Description: PGP signature ___

Re: PATCH: remove redundant methods in dejagnu.h

2018-12-03 Thread Jacob Bachmeyer
Ben Elliston wrote: I spotted this while reading dejagnu.h. There is no need to provide additional methods that peform the same runtime type conversion that C++ does for us. OK to commit? What revision of C++ added those runtime type conversions? Is it plausible that any projects out ther

PATCH: remove redundant methods in dejagnu.h

2018-12-03 Thread Ben Elliston
Hi Rob I spotted this while reading dejagnu.h. There is no need to provide additional methods that peform the same runtime type conversion that C++ does for us. OK to commit? Cheers, Ben 2018-12-03 Ben Elliston * dejagnu.h (TestState): Remove const char * variants of pass()