Re: PATCH: add support for verifying errors in internal unit tests [revised patch]

2018-12-07 Thread Ben Elliston
On Fri, Dec 07, 2018 at 08:53:37PM -0600, Jacob Bachmeyer wrote: > * testsuite/runtest.all/default_procs.tcl: > (lib_errpat_test, lib_errregexp_test, lib_err_test): New. > (lib_regexp_test): Fix copy-paste-edit error. > (lib_pat_test, lib_regexp_test, lib_ret_test, lib_bool

Re: PATCH: add support for verifying errors in internal unit tests [revised patch]

2018-12-07 Thread Jacob Bachmeyer
Ben Elliston wrote: On Fri, Dec 07, 2018 at 06:59:01PM -0600, Jacob Bachmeyer wrote: + if { [string match "$pattern" $result] } { + return 1 + } else { + return 0 + } This can be simplified to: return [string match $pattern $result] Done.

Re: PATCH: add support for verifying errors in internal unit tests

2018-12-07 Thread Ben Elliston
On Fri, Dec 07, 2018 at 06:59:01PM -0600, Jacob Bachmeyer wrote: > + if { [string match "$pattern" $result] } { > + return 1 > + } else { > + return 0 > + } This can be simplified to: return [string match $pattern $result] > + if { [regexp -- $regexp $result]

PATCH: add support for verifying errors in internal unit tests

2018-12-07 Thread Jacob Bachmeyer
This patch adds new procedures for verifying that errors are raised when appropriate. This patch also fixes some bugs introduced in previous work, including finally getting a very tricky quoting bit right for using eval in lib_*_test with lists of arguments. The proper quoting inhibits comman