Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]

2018-12-04 Thread Ben Elliston
On Tue, Dec 04, 2018 at 12:55:01AM -0600, Jacob Bachmeyer wrote: > Here is a separate patch for the NEWS file: Applied, thanks! Ben signature.asc Description: PGP signature ___ DejaGnu mailing list DejaGnu@gnu.org https://lists.gnu.org/mailman/listin

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]

2018-12-04 Thread Ben Elliston
On Tue, Dec 04, 2018 at 12:10:53AM -0600, Jacob Bachmeyer wrote: > * runtest.exp: Use new relative_filename procedure. > * doc/dejagnu.texi (relative_filename procedure): Add. > * lib/utils.exp (relative_filename): Add. > * testsuite/runtest.all/utils.test: Add tests for re

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]

2018-12-03 Thread Jacob Bachmeyer
Ben Elliston wrote: On Tue, Dec 04, 2018 at 12:10:53AM -0600, Jacob Bachmeyer wrote: While the GNU Coding Standards suggest using "file name" specifically; a quick grep shows that DejaGnu already has proc unix_clean_filename and no procedures that use "file_name" in their names, so consistenc

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]

2018-12-03 Thread Ben Elliston
On Tue, Dec 04, 2018 at 12:10:53AM -0600, Jacob Bachmeyer wrote: > While the GNU Coding Standards suggest using "file name" > specifically; a quick grep shows that DejaGnu already has proc > unix_clean_filename and no procedures that use "file_name" in their > names, so consistency suggests that t

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]

2018-12-03 Thread Jacob Bachmeyer
Ben Elliston wrote: On Mon, Dec 03, 2018 at 11:29:47PM -0600, Jacob Bachmeyer wrote: In other words, it probably should remain as "relative_file_name", since "realpath_relative" implies a different (and more extensive operation) as I see it. At the least, "realpath_relative" would apply "fil

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable

2018-12-03 Thread Ben Elliston
On Mon, Dec 03, 2018 at 11:29:47PM -0600, Jacob Bachmeyer wrote: > In other words, it probably should remain as "relative_file_name", > since "realpath_relative" implies a different (and more extensive > operation) as I see it. At the least, "realpath_relative" would > apply "file normalize" to b

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable

2018-12-03 Thread Jacob Bachmeyer
Ben Elliston wrote: On Mon, Dec 03, 2018 at 09:56:30PM -0600, Jacob Bachmeyer wrote: This is part of my ongoing efforts to improve DejaGnu's integration with Automake. I think that "relative_file_name" could be a useful utility procedure and will be able to fill any remaining gaps when subdi

Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable

2018-12-03 Thread Ben Elliston
On Mon, Dec 03, 2018 at 09:56:30PM -0600, Jacob Bachmeyer wrote: > This is part of my ongoing efforts to improve DejaGnu's integration > with Automake. I think that "relative_file_name" could be a useful > utility procedure and will be able to fill any remaining gaps when > subdir is eventually d

PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable

2018-12-03 Thread Jacob Bachmeyer
This is part of my ongoing efforts to improve DejaGnu's integration with Automake. I think that "relative_file_name" could be a useful utility procedure and will be able to fill any remaining gaps when subdir is eventually deprecated. This also replaces two slightly different ways of deriving