Re: Documenting test script arguments and revising runtest_file_p

2019-01-11 Thread Jacob Bachmeyer
Ben Elliston wrote: On Fri, Jan 11, 2019 at 10:38:05PM -0600, Jacob Bachmeyer wrote: Is the contents of the "runtests" variable part of the DejaGnu API currently? The variable is not documented and runtest_file_p exists to abstract its meaning. No. It should only be procs. We should b

Re: Documenting test script arguments and revising runtest_file_p

2019-01-11 Thread Ben Elliston
On Fri, Jan 11, 2019 at 10:38:05PM -0600, Jacob Bachmeyer wrote: > Is the contents of the "runtests" variable part of the DejaGnu API > currently? The variable is not documented and runtest_file_p exists > to abstract its meaning. No. It should only be procs. We should be providing accessor proc

Re: Documenting test script arguments and revising runtest_file_p

2019-01-11 Thread Jacob Bachmeyer
Ben Elliston wrote: On Fri, Jan 11, 2019 at 07:02:09PM -0600, Jacob Bachmeyer wrote: Also, runtest_file_p tries to hide the structure of runtests, but should also implicitly use it, instead of requiring that it be passed as an argument. Keep in mind that runtest_file_p is part of the

Re: Documenting test script arguments and revising runtest_file_p

2019-01-11 Thread Ben Elliston
On Fri, Jan 11, 2019 at 07:02:09PM -0600, Jacob Bachmeyer wrote: > Also, runtest_file_p tries to hide the structure of runtests, but > should also implicitly use it, instead of requiring that it be > passed as an argument. Keep in mind that runtest_file_p is part of the DejaGnu library API. It is

Documenting test script arguments and revising runtest_file_p

2019-01-11 Thread Jacob Bachmeyer
The recent questions about adding a test case led to my asking "How are test script arguments passed in DejaGnu?" and finding not only that the mechanism is not documented, but that it is another "surprise" variable: runtests. This mechanism is probably older than Tcl's [info script] command,