Re: DejaGnu unit testing protocol

2020-07-22 Thread Jacob Bachmeyer
David Malcolm wrote: On Wed, 2020-07-22 at 17:05 -0500, Jacob Bachmeyer wrote: [...] In terms of "other comments": FWIW within gcc, the jit.dg testsuite for libgccjit has a copy of host_execute ("fixed_host_execute") to workaround issues I've run into: https://gcc.gnu.org/git/?p=gcc.git;a=b

Re: DejaGnu unit testing protocol

2020-07-22 Thread Rob Savoye
On 7/22/20 5:06 PM, David Malcolm wrote: > (I also ran into the issue that dejagnu.h's pass/fail C functions > aren't thread-safe, which I hack around in my testsuite, replacing them > in multi-threaded tests with ones guarded by a mutex). I'll be honest, when I wrote dejagnu.h, I never thought

Re: DejaGnu unit testing protocol

2020-07-22 Thread David Malcolm
On Wed, 2020-07-22 at 17:05 -0500, Jacob Bachmeyer wrote: > I had been planning to look at this later, but fixing PR42399 > brought > this front-and-center. The DejaGnu unit testing protocol is not > (yet) > documented (will be fixed as part of PR42399) and there is a strange > quirk in its han

DejaGnu unit testing protocol

2020-07-22 Thread Jacob Bachmeyer
I had been planning to look at this later, but fixing PR42399 brought this front-and-center. The DejaGnu unit testing protocol is not (yet) documented (will be fixed as part of PR42399) and there is a strange quirk in its handler. What produces lines with prefixes matching {[0-9][0-9]:..:..:}

Re: [PATCH] Add riscv-sim.exp

2020-07-22 Thread Joel Sherrill
On 7/22/2020 8:53 AM, Rob Savoye wrote: > On 7/21/20 11:02 PM, Kito Cheng wrote: > >> Remote protocols need a port which means it's harder to parallel >> testing in a single machine, >> but I guess it could add some mechanism to randomly pick a port to prevent >> that. >Actually that's support

Re: [PATCH] Add riscv-sim.exp

2020-07-22 Thread Tom Tromey
Kito> Remote protocols need a port which means it's harder to parallel Kito> testing in a single machine, but I guess it could add some Kito> mechanism to randomly pick a port to prevent that. The gdb test suite already handles this; but also maybe it could be changed to use the pipe feature of "t

Re: [PATCH] Add riscv-sim.exp

2020-07-22 Thread Rob Savoye
On 7/21/20 11:02 PM, Kito Cheng wrote: > Remote protocols need a port which means it's harder to parallel > testing in a single machine, > but I guess it could add some mechanism to randomly pick a port to prevent > that. Actually that's supported for the remote protocol, it increments the por