Re: [PING^3][PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2020-06-19 Thread Maciej W. Rozycki
On Mon, 18 May 2020, Jacob Bachmeyer wrote: > You are looking for the calls matching attempts to invoke gnatmake using > "remote_exec host" and you may consider the braced strings containing > gnatmake commands to be the output of the test as that is what your > patches will change. (The first

[PATCH v2] target: Wrap linker flags into `-largs'/`-margs' for Ada

2020-06-19 Thread Maciej W. Rozycki
Unrecognized `gnatmake' switches are not implicitly passed on to the linker, so just pasting board `ldflags' and any other linker flags verbatim into `add_flags' to use for the invocation line of `gnatmake' will make them ignored at best. For example in a GCC test environment that has: set_boa

Re: GDB testsuite overrides default_target_compile and breaks

2020-06-19 Thread Jacob Bachmeyer
Tom Tromey wrote: Jacob> What is needed in brief: Jacob> (1) Merge the features of default_target_compile that the GDB Jacob> testsuite depends on upstream for 1.6.3. Jacob> (2) Find the actual extensibility that GDB needs here and add that Jacob> support to the default_target_compile rewrite sla

Re: [PATCH 0/3] Merge in gdb default_target_compile changes

2020-06-19 Thread Jacob Bachmeyer
Tom Tromey wrote: This series merges in gdb's changes to default_target_compile, updating them to follow newer conventions at the same time. I tested this using various parts of the gdb test suite (in particular Go and Rust). I also verified that, with this series in place, gdb does not use its

Re: GDB testsuite overrides default_target_compile and breaks

2020-06-19 Thread Rob Savoye
On 6/19/20 6:57 AM, Tom Tromey wrote: > FWIW this makes sense to me. I think it's never been a great idea to > have this override in gdb. Dejagnu wasn't very actively maintained for > a long time, and had low engagement from gdb developers, so it was more > like a convenient way to move forward.

[PATCH 3/3] Add Go support to default_target_compile

2020-06-19 Thread Tom Tromey
This adds Go support to default_target_compile. This comes from this gdb patch: commit a766d390bb857383a5f9ae80a102e1f8705f4c2e Author: Doug Evans Date: Wed Apr 25 14:07:23 2012 + Initial pass at Go language support. --- ChangeLog| 7 +++ doc/deja

[PATCH 1/3] Add early_flags to default_target_compile

2020-06-19 Thread Tom Tromey
This adds early_flags support to default_target_compile. This originated in this gdb patch: commit 6ebea266fd0a7a56c90db3ab6237ff9f6c919747 Author: Doug Evans Date: Fri Jul 24 15:24:37 2015 -0700 Workaround debian change to default value of --as-needed. gdb/testsu

[PATCH 0/3] Merge in gdb default_target_compile changes

2020-06-19 Thread Tom Tromey
This series merges in gdb's changes to default_target_compile, updating them to follow newer conventions at the same time. I tested this using various parts of the gdb test suite (in particular Go and Rust). I also verified that, with this series in place, gdb does not use its monkey-patched code

[PATCH 2/3] Add Rust support to default_target_compile

2020-06-19 Thread Tom Tromey
This adds support for the Rust language to default_target_compile. This comes from a gdb patch: commit 67218854b1987d89593ccaf5feaf5b29b1b976f2 Author: Tom Tromey Date: Tue Apr 26 19:38:43 2016 -0600 Update gdb test suite for Rust [...] 2016-05-17 Tom Tromey

Re: GDB testsuite overrides default_target_compile and breaks

2020-06-19 Thread Tom Tromey
I trimmed the cc list down to just gdb and dejagnu. Jacob> What is needed in brief: Jacob> (1) Merge the features of default_target_compile that the GDB Jacob> testsuite depends on upstream for 1.6.3. Jacob> (2) Find the actual extensibility that GDB needs here and add that Jacob> support to the d