Re: What to do with setup_{host, target, build}_hook and cleanup_target_hook procedures?

2019-02-03 Thread Ben Elliston
On Sun, Feb 03, 2019 at 10:27:20PM -0600, Jacob Bachmeyer wrote: > Speaking of that, I am also moving towards using the Texinfo @deffn > command for documenting procedures, so I ask whether each procedure > should get its own node or the {setup,cleanup}__hook > procedures should be grouped by ? I

Re: What to do with setup_{host, target, build}_hook and cleanup_target_hook procedures?

2019-02-03 Thread Ben Elliston
On Sun, Feb 03, 2019 at 10:27:20PM -0600, Jacob Bachmeyer wrote: > This issue with the code was found while writing documentation, so > the new documentation will at the least be included in the big > documentation patch I am currently working on. Should these code > changes also be rolled into t

Re: What to do with setup_{host, target, build}_hook and cleanup_target_hook procedures?

2019-02-03 Thread Jacob Bachmeyer
Ben Elliston wrote: On Fri, Feb 01, 2019 at 06:30:50PM -0600, Jacob Bachmeyer wrote: I propose: 1. Add cleanup_{build,host}_hook procedures. 2. Ensure that all *_hook procedures are empty and move all framework-related code to new procedures. That sounds fine. Can you please ma