Re: testsuite/lib/libsup.exp appears to be an interesting fossil

2018-12-11 Thread Rob Savoye
On 12/11/18 7:59 PM, Jacob Bachmeyer wrote: > Is there a known reason that this approach (an interactive Expect > subprocess) is not used, or was there simply not time to pursue it in > early 1996? In 1996, when that file was written, nobody was using the unit test API at all. Later on, that d

testsuite/lib/libsup.exp appears to be an interesting fossil

2018-12-11 Thread Jacob Bachmeyer
While recently improving the DejaGnu testsuite, I found that using "pass" in a unit test case that loads framework.exp produced an error: "PASS doesn't exist in incr_count". The immediate solution was "well, of course that does not work" and just writing {puts "PASSED: ..."} instead, but libs

Re: PATCH: simplify regular expressions

2018-12-11 Thread Jacob Bachmeyer
Pedro Alves wrote: On 12/10/2018 10:30 PM, Jacob Bachmeyer wrote: Should DejaGnu eventually support GDB's MI mode, possibly in another module? Would this be for GDB's own testing, or for something else? The intent was (future) use of GDB as a tool within DejaGnu as part of tests

Re: PATCH: simplify regular expressions

2018-12-11 Thread Ben Elliston
On Tue, Dec 11, 2018 at 03:25:06PM +, Pedro Alves wrote: > Would this be for GDB's own testing, or for something else? No, for controlling GDB from DejaGnu. Consider a version of gdb_comm_delete_breakpoints that interacts with the controlled GDB process using MI instead of matching string out

Re: PATCH: clean up whitespace in manual

2018-12-11 Thread Rob Savoye
On 12/10/18 11:00 PM, Jacob Bachmeyer wrote: > That is on my local TODO list, after quite a bit of other code and > documentation work, including sorting out "which of these procedures > should be in an exported API and which should be considered internal?"  > That it is mentioned at all suggests

Re: PATCH: simplify regular expressions

2018-12-11 Thread Pedro Alves
On 12/10/2018 10:30 PM, Jacob Bachmeyer wrote: > Should DejaGnu eventually support GDB's MI mode, possibly in another module? Would this be for GDB's own testing, or for something else? GDB already has MI testcases driven by dejagnu. Most live under gdb/testsuite/gdb.mi/ https://sourceware.or

Re: PATCH: simplify regular expressions

2018-12-11 Thread Rob Savoye
On 12/11/18 2:55 AM, Ben Elliston wrote: > On Mon, Dec 10, 2018 at 04:30:49PM -0600, Jacob Bachmeyer wrote: > >> GDB has changed somewhat over the years; are the strings those >> modules seek still valid or do we need to accept both "old" and >> "new" message sets? Should DejaGnu eventually suppo

Re: PATCH: testsuite improvements

2018-12-11 Thread Ben Elliston
On Mon, Dec 10, 2018 at 06:57:17PM -0600, Jacob Bachmeyer wrote: > This patch fixes some issues with the testsuite. Excellent work. Thank you! Cheers, Ben signature.asc Description: PGP signature ___ DejaGnu mailing list DejaGnu@gnu.org https://lists

Re: PATCH: simplify regular expressions

2018-12-11 Thread Ben Elliston
On Mon, Dec 10, 2018 at 04:30:49PM -0600, Jacob Bachmeyer wrote: > GDB has changed somewhat over the years; are the strings those > modules seek still valid or do we need to accept both "old" and > "new" message sets? Should DejaGnu eventually support GDB's MI > mode, possibly in another module?