Bug#830207: Next try

2017-02-25 Thread David Rabel
Hi again, On 19.02.2017 22:40, Rolf Leggewie wrote: >>> The Depends and Build-Depends lines look surprisingly long.[...] >> I copied both Build-Depends and Depends from the upstream control file. >> I'm not too familiar with ${misc:Depends} and ${shlibs:Depends} . Maybe >> you would like to fix th

Bug#830207: Next try

2017-02-25 Thread David Rabel
Hi Rolf, On 19.02.2017 22:40, Rolf Leggewie wrote: > Part of the work as maintainer and especially when doing an ITP is to > verify the code is indeed DFSG-free. Personally, I'd have trouble with > ambiguity in the form of "Well, I can't really be certain if the > software is licensed as GPL, LGP

Bug#830207: Next try

2017-02-20 Thread David Rabel
On 20.02.2017 22:29, David Rabel wrote: > On 19.02.2017 22:40, Rolf Leggewie wrote: >> This is usually only necessary if >> those autogenerated files are old and do not support newer platforms. >> That's when you need to autoreconf. Otherwise, it's unnecessary but it >> does have the benefit of f

Bug#830207: Next try

2017-02-20 Thread David Rabel
Hi there, On 19.02.2017 22:40, Rolf Leggewie wrote: > On 19.02.2017 19:45, David Rabel wrote: >> I think you are wrong here. intltoolize is not run by autoreconf. > > That's what I read during my research about dh-autoreconf (not > autoreconf). It's entirely possible that I am mistaken. As I sai

Bug#830207: Next try

2017-02-19 Thread Rolf Leggewie
Hello and good morning! On 19.02.2017 19:45, David Rabel wrote: > dpkg-source emits a warning concerning the fiels that dh-clean deletes, > e.g.: > > dpkg-source: warning: ignoring deletion of file missing, use > --include-removal to override > > Is this a problem? No, that's just informationa

Bug#830207: Next try

2017-02-19 Thread David Rabel
Me again. ;) dpkg-source emits a warning concerning the fiels that dh-clean deletes, e.g.: dpkg-source: warning: ignoring deletion of file missing, use --include-removal to override Is this a problem? David signature.asc Description: OpenPGP digital signature

Bug#830207: Next try

2017-02-19 Thread David Rabel
Good morning, On 19.02.2017 00:48, Rolf Leggewie wrote: >>> I am sure Osmo did not intend to release as public domain. >> What you actually say is: IF we leave it as it is, the worst case is >> that the software could be public domain. > > No. The software has whatever license it has. We are ju

Bug#830207: Next try

2017-02-18 Thread Rolf Leggewie
On 19.02.2017 04:12, David Rabel wrote: > I was just thinking: Do we have to add a paragraph in debian/copyright > for files we delete with debian/clean? Yes, absolutely. The only other option is to create a separate dfsg-free upstream tarball and strip the relevant files from that tarball. In y

Bug#830207: Next try

2017-02-18 Thread Rolf Leggewie
Good morning David, On 19.02.2017 03:59, David Rabel wrote: > Hi Rolf, > > a general question: Are you OK with the way I commit every step in git > or would you prefer that I clean up the history a little bit before pushing? Whatever you think makes most sense. Your style looks absolutely fine t

Bug#830207: Next try

2017-02-18 Thread David Rabel
On 18.02.2017 20:59, David Rabel wrote: >> 329aa8ce287 >> "Other" is not a good name for License. I suggest to follow >> https://tracker.debian.org/media/packages/g/granule/copyright-1.4.0-7-4 >> or https://github.com/giuliopaci/SPro/blob/master/debian/copyright which >> I found doing a quick Goog

Bug#830207: Next try

2017-02-18 Thread David Rabel
Hi Rolf, a general question: Are you OK with the way I commit every step in git or would you prefer that I clean up the history a little bit before pushing? On 18.02.2017 20:14, Rolf Leggewie wrote: > 60fd5fd4c > It's a trivial fix, but if upstream has that spelling error I think it > would be be

Bug#830207: Next try

2017-02-18 Thread Rolf Leggewie
On 18.02.2017 20:37, David Rabel wrote: > Hi there, > > I uploaded a new audio-recorder package to mentors: > https://mentors.debian.net/package/audio-recorder Awesome! Thanks. I see you pushed changes to github so I will focus my review on what's up there, assuming it is identical to what's on

Bug#830207: Next try

2017-02-18 Thread David Rabel
Hi there, I uploaded a new audio-recorder package to mentors: https://mentors.debian.net/package/audio-recorder Mainly it is an update of the debian/copyright file. But while I edited it, I found a lot of auto-generated files in the source tarball. So I deleted them via dquilt patch. I hope this