Bug#798045: RFS: golang-github-streadway-amqp

2015-09-04 Thread Dmitry Smirnov
On Friday 04 September 2015 21:06:38 Alexandre Viau wrote: > I thought that this was the reason that we included a full copy of the > license in debian/copyright. Copyright must be comprehensive so we include full text of all licenses except those in "/usr/share/common-licenses/". > I have rena

Bug#798045: RFS: golang-github-streadway-amqp

2015-09-04 Thread Alexandre Viau
Hello, On 04/09/15 08:51 PM, Dmitry Smirnov wrote: > I mean their BSD-like license is neither BSD-2-clause [1] nor BSD-3-clause > [2] hence it would be wrong to call it "BSD-2-clause" because the text of the > license is not canonical. I thought that this was the reason that we included a full

Bug#798045: RFS: golang-github-streadway-amqp

2015-09-04 Thread Dmitry Smirnov
On Friday 04 September 2015 20:24:04 Alexandre Viau wrote: > On 04/09/15 07:36 PM, Dmitry Smirnov wrote: > > Also I'm not sure about license name: text of the license is not classic > > BSD-2-clause so perhaps it is better written as "BSD-2-clause/AMPQ" or > > something like this... > > hmm, AMPQ?

Bug#798045: RFS: golang-github-streadway-amqp

2015-09-04 Thread Alexandre Viau
Hello, On 04/09/15 07:36 PM, Dmitry Smirnov wrote: > > You actually need to check each and every file... > Sorry, I will check every file from now on. I really shouldn't make this simple mistake. I have fixed it in the repository. > Also I'm not sure about license name: text of the license is n

Bug#798045: RFS: golang-github-streadway-amqp

2015-09-04 Thread Dmitry Smirnov
On Friday 04 September 2015 15:31:53 Alexandre Viau wrote: > Thank you for all the reviews. No worries. :) > Could you please review golang-github-streadway-amqp? Well, some license information is missing, see amqp/spec/amqp0-9-1.stripped.extended.xml You actually need to check each and e

Bug#798045: RFS: golang-github-streadway-amqp

2015-09-04 Thread Alexandre Viau
Hello Dimitry, Thank you for all the reviews. Could you please review golang-github-streadway-amqp? It is available on Alioth: - git.debian.org:/git/pkg-go/packages/golang-github-streadway-amqp Thanks, -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digita