Re: unblock (pre-approval): kde-workspace/4:4.11.13-2.1

2015-04-06 Thread Sune Vuorela
On Monday 06 April 2015 20:29:27 John Paul Adrian Glaubitz wrote: > I wasn't actually aware that there additional code in the sysvinit init > script that would customize or even create a new kdmrc. The kdm package > actually ships a kdmrc file, so I just added a few lines to make the > package sys

Re: unblock (pre-approval): kde-workspace/4:4.11.13-2.1

2015-04-06 Thread John Paul Adrian Glaubitz
Hi Sune! On 04/06/2015 07:31 PM, Sune Vuorela wrote: > I wouldn't mind a better systemd integration, but your patch seems half done. > > You have lost the integration with the desktop-base package and the related > theming. Indeed, as Moritz pointed out here [1], I have overlooked this part. >

Re: unblock (pre-approval): kde-workspace/4:4.11.13-2.1

2015-04-06 Thread Sune Vuorela
On Thursday 02 April 2015 21:10:00 John Paul Adrian Glaubitz wrote: > On 04/02/2015 04:26 PM, John Paul Adrian Glaubitz wrote: > > Attaching revision 2 of my debdiff. > > While reviewing my own patch, I noticed a typo in the change I made > in the debian/rules file (overriden_command -> overridden

Re: unblock (pre-approval): kde-workspace/4:4.11.13-2.1

2015-04-02 Thread John Paul Adrian Glaubitz
On 04/02/2015 04:26 PM, John Paul Adrian Glaubitz wrote: > Attaching revision 2 of my debdiff. While reviewing my own patch, I noticed a typo in the change I made in the debian/rules file (overriden_command -> overridden_command). I have fixed this now and made the changelog entry slightly more a

Re: unblock (pre-approval): kde-workspace/4:4.11.13-2.1

2015-04-02 Thread John Paul Adrian Glaubitz
On 04/02/2015 01:47 PM, John Paul Adrian Glaubitz wrote: > I am attaching the full debdiff which is rather small and should > be easy for review. I cleaned up the patch a bit. I fixed the tabstops and added an additional line to the debian/changelog indicating that the new file debian/kdm.service