Re: yasnippet commits review

2023-01-30 Thread Aymeric Agon-Rambosson
Hi Nicholas, Le dimanche 29 janvier 2023 à 21:19, Nicholas D Steeves a écrit : Have you already created an account, or are you waiting for approval? https://wiki.debian.org/FrontPage?action=newaccount I am currently waiting for approval. I have cced you on my mail asking for account

Re: yasnippet commits review

2023-01-29 Thread Nicholas D Steeves
Hi Aymeric, Aymeric Agon-Rambosson writes: > Hi Nicholas, > > Le dimanche 29 janvier 2023 à 13:51, Nicholas D Steeves > a écrit : > >> I agree, the wiki is a good place to centralise information. >> Linking to >> that article can then be used to avoid needing to reexplaining >> things; >> it

Re: yasnippet commits review

2023-01-29 Thread Aymeric Agon-Rambosson
Hi Nicholas, Le dimanche 29 janvier 2023 à 13:51, Nicholas D Steeves a écrit : I agree, the wiki is a good place to centralise information. Linking to that article can then be used to avoid needing to reexplaining things; it also prevents gating when you link to it from package that need

Re: yasnippet commits review

2023-01-29 Thread Nicholas D Steeves
Hi Aymeric, tldr: We only have about week to upload the fix, so I'd prefer to merge what I reviewed (where you used a patch) right now and upload ASAP. Aymeric Agon-Rambosson writes: > Le dimanche 22 janvier 2023 à 17:31, Nicholas D Steeves > a écrit : > >> It would be nice to see some of the

Re: yasnippet commits review

2023-01-23 Thread Aymeric Agon-Rambosson
Hi Nicholas, Le dimanche 22 janvier 2023 à 17:31, Nicholas D Steeves a écrit : It would be nice to see some of the above text in the patch header and/or Debian changelog (it's not relevant for the upstream PR as far as I can tell) I don't think it is relevant to this specific patch eit

Re: yasnippet commits review

2023-01-22 Thread Nicholas D Steeves
Hi Aymeric, Aymeric Agon-Rambosson writes: > According to the function `comp-trampoline-compile', the > EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION environment variable > does not prevent trampoline compilation, only the saving of the > output of said trampoline compilation to the file system.

Re: yasnippet commits review

2023-01-15 Thread David Bremner
Aymeric Agon-Rambosson writes: > Hello David, > > Le dimanche 15 janvier 2023 à 07:05, David Bremner > a écrit : > >> Apologies, I haven't had time to follow this discussion very >> well, but I >> should note setting EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION=t >> in the >> environment may

Re: yasnippet commits review

2023-01-15 Thread Aymeric Agon-Rambosson
Hello David, Le dimanche 15 janvier 2023 à 07:05, David Bremner a écrit : Apologies, I haven't had time to follow this discussion very well, but I should note setting EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION=t in the environment may help suppress trampoline compilation. According to

Re: yasnippet commits review

2023-01-15 Thread David Bremner
Aymeric Agon-Rambosson writes: > > I have a patch for the remaining three failures. It was the > trampoline compilation of the primitive buffer-list that made the > three tests fail. This is similar to what I got in projectile. I > am not exactly sure *how* the trampoline compilation makes the

Re: yasnippet commits review

2023-01-15 Thread Aymeric Agon-Rambosson
Hello Nicholas, Le jeudi 12 janvier 2023 à 15:25, Nicholas D Steeves a écrit : Wonderful, it looks good to me, so I've merged your work. I'll CC you when I ask the upstream community about the remaining three failures. I have a patch for the remaining three failures. It was the trampo

Re: yasnippet commits review

2023-01-10 Thread Nicholas D Steeves
Hi Aymeric, Aymeric Agon-Rambosson writes: > > Le dimanche 8 janvier 2023 à 18:12, Nicholas D Steeves > a écrit : > >> I've created the branch "temp-agon-reviewed_by_sten" which is >> fast-forwardable relative from "temp". > > Very well, I've seen the branch. Since we can rewrite history as >

Re: yasnippet commits review

2023-01-10 Thread Aymeric Agon-Rambosson
Hello Nicholas, Le dimanche 8 janvier 2023 à 18:12, Nicholas D Steeves a écrit : I've created the branch "temp-agon-reviewed_by_sten" which is fast-forwardable relative from "temp". This was necessary because the following are not doc-related...self tests for core functionality should

Re: yasnippet commits review

2023-01-08 Thread Nicholas D Steeves
Hi Aymeric, I've created the branch "temp-agon-reviewed_by_sten" which is fast-forwardable relative from "temp". This was necessary because the following are not doc-related...self tests for core functionality shouldn't break: 3 unexpected results: FAILED basic-jit-loading FAI

Re: yasnippet commits review

2023-01-04 Thread Aymeric Agon-Rambosson
Hello Nicholas, Le mercredi 4 janvier 2023 à 13:13, Nicholas D Steeves a écrit : ca55bc8: Nice find, and fix, thank you! (I haven't tested it yet, but assume you have, that it's good, and that it will pass when I test it) I have, and I have checked that the generated HTML documentation