Re: lintian: shlib-read-write-env

2017-02-01 Thread Simon McVittie
On Wed, 01 Feb 2017 at 11:02:08 +0100, Vincent Danjean wrote: > In an MT context, such a program should probably use setenv between > the fork and the exec (ie not in MT context) Calling non-async-signal safe functions after fork but before exec, in a process that uses threads, is undefined behavi

Re: lintian: shlib-read-write-env

2017-02-01 Thread Vincent Danjean
Le 31/01/2017 à 16:56, Christian Seiler a écrit : > (Any program that calls setenv() will call getenv() as well at > some point, otherwise you could simply drop the setenv() completely; Not necessarily. Instead of calling getenv, it can call fork+exec (that will run an other program, MT or not, in

Re: lintian: shlib-read-write-env

2017-01-31 Thread Mathieu Malaterre
On Tue, Jan 31, 2017 at 4:56 PM, Christian Seiler wrote: > On 01/31/2017 04:49 PM, Ben Hutchings wrote: >> On Tue, 2017-01-31 at 14:23 +0100, Christian Seiler wrote: >>> On 01/31/2017 11:15 AM, Mathieu Malaterre wrote: I'd like to discuss addition of a new lintian checks for getenv/seten

Re: lintian: shlib-read-write-env

2017-01-31 Thread Christian Seiler
On 01/31/2017 04:49 PM, Ben Hutchings wrote: > On Tue, 2017-01-31 at 14:23 +0100, Christian Seiler wrote: >> On 01/31/2017 11:15 AM, Mathieu Malaterre wrote: >>> I'd like to discuss addition of a new lintian checks for >>> getenv/setenv/putenv used in shared libraries. >> >> Why getenv() though? It

Re: lintian: shlib-read-write-env

2017-01-31 Thread Ben Hutchings
On Tue, 2017-01-31 at 14:23 +0100, Christian Seiler wrote: > On 01/31/2017 11:15 AM, Mathieu Malaterre wrote: > > I'd like to discuss addition of a new lintian checks for > > getenv/setenv/putenv used in shared libraries. > > Why getenv() though? It just reads the environment. > > From what you li

Re: lintian: shlib-read-write-env

2017-01-31 Thread Christian Seiler
On 01/31/2017 11:15 AM, Mathieu Malaterre wrote: > I'd like to discuss addition of a new lintian checks for > getenv/setenv/putenv used in shared libraries. Why getenv() though? It just reads the environment. >From what you link yourself: | The getenv and secure_getenv functions can be safely use

Re: lintian: shlib-read-write-env

2017-01-31 Thread Mathieu Malaterre
On Tue, Jan 31, 2017 at 12:14 PM, Simon McVittie wrote: > On Tue, 31 Jan 2017 at 11:15:32 +0100, Mathieu Malaterre wrote: >> I'd like to discuss addition of a new lintian checks for >> getenv/setenv/putenv used in shared libraries. > > A massive number of libraries call getenv(). This is not somet

Re: lintian: shlib-read-write-env

2017-01-31 Thread Mathieu Malaterre
On Tue, Jan 31, 2017 at 11:26 AM, Andrey Rahmatullin wrote: > On Tue, Jan 31, 2017 at 11:15:32AM +0100, Mathieu Malaterre wrote: >> I'd like to discuss addition of a new lintian checks for >> getenv/setenv/putenv used in shared libraries. > Do you know any packages that would fail that? > Did you

Re: lintian: shlib-read-write-env

2017-01-31 Thread Simon McVittie
On Tue, 31 Jan 2017 at 11:15:32 +0100, Mathieu Malaterre wrote: > I'd like to discuss addition of a new lintian checks for > getenv/setenv/putenv used in shared libraries. A massive number of libraries call getenv(). This is not something that you can just ban. In many cases (any D-Bus implementat

Re: lintian: shlib-read-write-env

2017-01-31 Thread Andrey Rahmatullin
On Tue, Jan 31, 2017 at 11:15:32AM +0100, Mathieu Malaterre wrote: > I'd like to discuss addition of a new lintian checks for > getenv/setenv/putenv used in shared libraries. Do you know any packages that would fail that? Did you mean *jpeg* ones would? -- WBR, wRAR signature.asc Description: P