Re: Using -Werror in CFLAGS for a debian package build

2011-07-24 Thread Bernhard R. Link
* Russ Allbery [110724 03:23]: > > I, personally, consider all of those warnings bugs. Well, unused > > variables aren't problems per se, but often can give good hints where > > there *might* be some bug. > > Oh, sure, I agree. But sometimes it's not a good idea to immediately > escalate a whole

Re: Using -Werror in CFLAGS for a debian package build

2011-07-23 Thread Russ Allbery
Enrico Weigelt writes: > * Russ Allbery schrieb: >> If -Werror had not been disabled for this warning, my guess is that >> nearly every package using -Wall -Werror not previously tested with 4.6 >> would FTBFS. > I, personally, consider all of those warnings bugs. Well, unused > variables aren'

Re: Using -Werror in CFLAGS for a debian package build

2011-07-23 Thread Enrico Weigelt
* Russ Allbery schrieb: > If -Werror had not been disabled for this warning, my guess is that nearly > every package using -Wall -Werror not previously tested with 4.6 would > FTBFS. I, personally, consider all of those warnings bugs. Well, unused variables aren't problems per se, but often can

Re: Using -Werror in CFLAGS for a debian package build

2011-05-22 Thread Simon McVittie
On Mon, 23 May 2011 at 01:44:03 +0200, Goswin von Brederlow wrote: > Or the reverse > > gcc -Wformat=error gcc -Wno-error -Wformat -Werror=format You might also be interested in m4/tp-compiler-warnings.m4 in telepathy-glib. Usage looks like this: TP_COMPILER_WARNINGS([ERROR_CFLAGS],

Re: Using -Werror in CFLAGS for a debian package build

2011-05-22 Thread Goswin von Brederlow
peter green writes: > (note: this message quotes from multiple mails by different people) > > Wouter>First and foremost, I do not believe that setting -Werror in a > Wouter>debian/rules file is the best way to maintain a package; -Werror is a > Wouter>development option which should not be used i

Re: Using -Werror in CFLAGS for a debian package build

2011-05-22 Thread Russ Allbery
peter green writes: > Is this really THAT big a deal? Is it really worth making dubious > changes to build dependencies (gcc in this case but a similar saga is > going on with dash) to temporarlly hide (and therefore make harder to > fix) FTBFS bugs that are usually trivial to fix in the package

Re: Using -Werror in CFLAGS for a debian package build

2011-05-22 Thread peter green
(note: this message quotes from multiple mails by different people) Wouter>First and foremost, I do not believe that setting -Werror in a Wouter>debian/rules file is the best way to maintain a package; -Werror is a Wouter>development option which should not be used in a release build (which a Wou

Re: Using -Werror in CFLAGS for a debian package build

2011-05-20 Thread Goswin von Brederlow
Didier Raboud writes: > Wouter Verhelst wrote: > >> I was working on nbd-server upstream, and so had ran ./configure with >> CFLAGS='-Wall -Werror', which I consider good practice when writing C >> code. >> >> What I didn't notice immediately was that gcc was emitting some >> warnings, but that

Re: Using -Werror in CFLAGS for a debian package build

2011-05-20 Thread Didier Raboud
Wouter Verhelst wrote: > I was working on nbd-server upstream, and so had ran ./configure with > CFLAGS='-Wall -Werror', which I consider good practice when writing C > code. > > What I didn't notice immediately was that gcc was emitting some > warnings, but that the -Werror option was not honore

Re: Using -Werror in CFLAGS for a debian package build

2011-05-17 Thread Charles Plessy
Le Tue, May 17, 2011 at 01:31:14AM +0200, Wouter Verhelst a écrit : > > What I didn't notice immediately was that gcc was emitting some > warnings, but that the -Werror option was not honored for those > warnings. Investigating turned up #615157 (Cc'd): the gcc maintainers > have decided to disabl

Re: Using -Werror in CFLAGS for a debian package build

2011-05-16 Thread Wouter Verhelst
On Mon, May 16, 2011 at 05:04:07PM -0700, Russ Allbery wrote: > Wouter Verhelst writes: > > > What I didn't notice immediately was that gcc was emitting some > > warnings, but that the -Werror option was not honored for those > > warnings. Investigating turned up #615157 (Cc'd): the gcc maintaine

Re: Using -Werror in CFLAGS for a debian package build

2011-05-16 Thread Sune Vuorela
On 2011-05-17, Russ Allbery wrote: > I don't like seeing us modify upstream compiler behavior in Debian this > way, but I can understand not wanting to introduce what could have easily > been hundreds of failures. (The problem, of course, is that those > failures are still latent, and unless we'r

Re: Using -Werror in CFLAGS for a debian package build

2011-05-16 Thread Russ Allbery
Wouter Verhelst writes: > What I didn't notice immediately was that gcc was emitting some > warnings, but that the -Werror option was not honored for those > warnings. Investigating turned up #615157 (Cc'd): the gcc maintainers > have decided to disable -Werror for some new warnings, because othe