Re: Help to review a patch in ELisp

2014-11-23 Thread Stéphane Aulery
Hello, Thank you very much for your accurate answers. I forwarded to the author for a decision knowingly. Regards, -- Stéphane Aulery -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https

Re: Help to review a patch in ELisp

2014-11-21 Thread Remi Vanicat
Stéphane Aulery writes: > Hello, > > I am looking for a person who knows enough to verify a ELisp patch. The > patch is supposed to fix a problem of space in file names [1], upstream > unfortunately does not have the in-house expertise [2]. > > Volunteers? The change to elisp only touch one rege

Re: Help to review a patch in ELisp

2014-11-21 Thread Matthias Urlichs
Hi, Josh Triplett: > > + sed -e 's/.* .*/\"&\"/' > $LIST_FILE > > > I can't speak for the rest of the patch without digging into quite a bit > of the context and assumptions in the elisp, but regarding this bit, > rather than checking for spaces and only quoting filenames then, just > *alw

Re: Help to review a patch in ELisp

2014-11-20 Thread Josh Triplett
Stéphane Aulery wrote: > I am looking for a person who knows enough to verify a ELisp patch. The > patch is supposed to fix a problem of space in file names [1], upstream > unfortunately does not have the in-house expertise [2]. [...] > diff -r -u cscope-15.7a/contrib/xcscope/cscope-indexer > chan