Re: Inert DEB_BUILD_OPTIONS noopt in debian/rules files

2014-10-08 Thread Guillem Jover
On Mon, 2014-10-06 at 19:10:47 +0200, Andreas Metzler wrote: > Guillem Jover wrote: > > On Mon, 2014-10-06 at 01:55:01 +0200, Jakub Wilk wrote: > > > Why? > > > Because make does not (yet) pass make variables to $(shell) subshells. > [...] > > Try this: > > > $ make -f debian/rules DEB_BUILD_O

Re: Inert DEB_BUILD_OPTIONS noopt in debian/rules files

2014-10-06 Thread Andreas Metzler
Guillem Jover wrote: > On Mon, 2014-10-06 at 01:55:01 +0200, Jakub Wilk wrote: [...] >> Why? > Because make does not (yet) pass make variables to $(shell) subshells. [...] > Try this: > $ make -f debian/rules DEB_BUILD_OPTIONS=noopt build > instead. This just breaks the interface. We could of

Re: Inert DEB_BUILD_OPTIONS noopt in debian/rules files

2014-10-05 Thread Guillem Jover
Hi! On Mon, 2014-10-06 at 01:55:01 +0200, Jakub Wilk wrote: > * Guillem Jover , 2014-10-06, 01:33: > >I realized that any debian/rules file that calls dpkg-buildflags through > >make's $(shell) function will not honor at least noopt from > >DEB_BUILD_OPTIONS, which affects the build flags returned

Re: Inert DEB_BUILD_OPTIONS noopt in debian/rules files

2014-10-05 Thread Jakub Wilk
* Guillem Jover , 2014-10-06, 01:33: I realized that any debian/rules file that calls dpkg-buildflags through make's $(shell) function will not honor at least noopt from DEB_BUILD_OPTIONS, which affects the build flags returned by dpkg-buildflags. Why? any package handling the flags inline w

Inert DEB_BUILD_OPTIONS noopt in debian/rules files

2014-10-05 Thread Guillem Jover
Hi! While going through the dpkg codebase, I realized that any debian/rules file that calls dpkg-buildflags through make's $(shell) function will not honor at least noopt from DEB_BUILD_OPTIONS, which affects the build flags returned by dpkg-buildflags. This is fixed in dpkg 1.17.14 buildflags.mk