Re: Generated files and patch systems

2008-05-25 Thread Goswin von Brederlow
Neil Williams <[EMAIL PROTECTED]> writes: > I'm getting into a crazy situation with this lintian warning: > > patch-system-but-direct-changes-in-diff > > I've removed one diversion from libgpewidget but I still need to use one > and this requires a patch to configure.ac using dpatch. This then > r

Re: Generated files and patch systems

2008-05-25 Thread Raphael Hertzog
On Sun, 25 May 2008, Mark Brown wrote: > On Sun, May 25, 2008 at 01:07:56PM +0100, Neil Williams wrote: > > > So I am running the relevant autotools at build time but I still get the > > warning. > > If you run autotools at build time you should also ensure that the > changes which autotools make

Re: Generated files and patch systems

2008-05-25 Thread Russ Allbery
Neil Williams <[EMAIL PROTECTED]> writes: > On Sun, 2008-05-25 at 13:19 +0100, Mark Brown wrote: >> If you run autotools at build time you should also ensure that the >> changes which autotools makes are reverted in the clean target. This >> means that your diff doesn't get cluttered with automat

Re: Generated files and patch systems

2008-05-25 Thread Neil Williams
On Sun, 2008-05-25 at 14:01 +0100, Neil Williams wrote: > On Sun, 2008-05-25 at 13:19 +0100, Mark Brown wrote: > > On Sun, May 25, 2008 at 01:07:56PM +0100, Neil Williams wrote: > > > > > So I am running the relevant autotools at build time but I still get the > > > warning. > > > > If you run au

Re: Generated files and patch systems

2008-05-25 Thread Neil Williams
On Sun, 2008-05-25 at 13:19 +0100, Mark Brown wrote: > On Sun, May 25, 2008 at 01:07:56PM +0100, Neil Williams wrote: > > > So I am running the relevant autotools at build time but I still get the > > warning. > > If you run autotools at build time you should also ensure that the > changes which

Re: Generated files and patch systems

2008-05-25 Thread Mark Brown
On Sun, May 25, 2008 at 01:07:56PM +0100, Neil Williams wrote: > So I am running the relevant autotools at build time but I still get the > warning. If you run autotools at build time you should also ensure that the changes which autotools makes are reverted in the clean target. This means that

Generated files and patch systems

2008-05-25 Thread Neil Williams
I'm getting into a crazy situation with this lintian warning: patch-system-but-direct-changes-in-diff I've removed one diversion from libgpewidget but I still need to use one and this requires a patch to configure.ac using dpatch. This then regenerates configure and aclocal.m4. I think patch-sys