Processed: Re: Bug#676006: temporary patch broken

2012-06-18 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > found 676006 0.5.0~svn5126+dfsg.1-1 Bug #676006 {Done: Gilles Filippini } [src:navit] navit: FTBFS: RenderArea.cpp:248:44: error: taking address of temporary array Marked as found in versions navit/0.5.0~svn5126+dfsg.1-1; no longer marked as fix

Bug#676006: temporary patch broken

2012-06-18 Thread Julian Taylor
found 676006 0.5.0~svn5126+dfsg.1-1 severity 676006 normal thanks On 06/18/2012 10:53 PM, Gilles Filippini wrote: > > The issue reported by g++ "taking address of temporary array" *is* > fixed. In this context (AIUI), "temporary" means that there is no > certainty that the address is still valid

Bug#676006: temporary patch broken

2012-06-18 Thread Gilles Filippini
Julian Taylor a écrit , Le 17/06/2012 17:11: > how does that patch fix the issue? Hi, The issue reported by g++ "taking address of temporary array" *is* fixed. In this context (AIUI), "temporary" means that there is no certainty that the address is still valid at the time callback_list_call_attr_

Bug#676006: temporary patch broken

2012-06-17 Thread Julian Taylor
how does that patch fix the issue? it still takes an address of a temporary, just in a way that the compiler can't detect it anymore. a correct fix is to copy the value into the original buffer (which then must be non-const) and not to swap the (incompatible) pointers. or allocate a global memory