On Mon, Dec 04, 2006 at 10:46:18AM +0100, Michael Vogt wrote:
> Unfortunately this patch is not enough because BigBuf is deleted
[...]
> right now. But testing feedback would be great :)
I've verified that the problem still persists with the apt which is
currently in the archive. I've also tested
On Thu, Nov 30, 2006 at 10:56:52AM +0100, Andreas Henriksson wrote:
> On Thu, Nov 30, 2006 at 08:49:26AM +0100, Jens Seidel wrote:
> > If the buffer needs to be longer by one than Bins you probably also need
> > +if (Bins.length() >= sizeof(Buffer))
>
> Good catch, thanks!
>
> Updated patch attac
> Updated patch attached.
>
>
> I wonder what the second part of this is good for:
>
> if (Bins.empty() == true || Bins.length() >= 102400)
> return 0;
>
> Oh, well that's a high enough number that it probably won't be(come)
> a real world problem and if w
* Andreas Henriksson ([EMAIL PROTECTED]) [061130 02:04]:
> Updated patch attached.
>
>
> I wonder what the second part of this is good for:
>
> if (Bins.empty() == true || Bins.length() >= 102400)
> return 0;
>
> Oh, well that's a high enough number that i
On Thu, Nov 30, 2006 at 08:49:26AM +0100, Jens Seidel wrote:
> If the buffer needs to be longer by one than Bins you probably also need
> +if (Bins.length() >= sizeof(Buffer))
Good catch, thanks!
Updated patch attached.
I wonder what the second part of this is good for:
On Thu, Nov 30, 2006 at 01:06:16AM +0100, Andreas Henriksson wrote:
> Patch attached.
>
>
> Regards,
> Andreas Henriksson
> diff -ur apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc
> apt-0.6.46.3.fix/apt-pkg/deb/debsrcrecords.cc
> --- apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc 2006-03-02 14:44:28.
tags 400874 + patch
thanks
Here's the off-by-one fix for apt. Now that it's solved it seems so
obvious... valgrind was right! (Could someone please rerun valgrind with
this patch applied?!)
Please verify for correctness, this patch "works for me" (and in my
current state seems to be the right
7 matches
Mail list logo
