Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-16 Thread Sven Geuer
Hi Thorsten, see https://salsa.debian.org/sven-geuer/rng-tools-debian for what, according to my tests, fixes the issue. Cheers, Sven -- GPG Fingerprint 3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585 signature.asc Description: This is a digitally signed message part

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-15 Thread Thorsten Glaser
On Thu, 16 Jan 2025, Luca Boccassi wrote: >This is an anti-pattern, and best avoided. What's the problem if the >script runs twice? If it just detects things it should be just fine, Extra effort, though. And, in general, TOCTOU, but probably not applicable here. bye, //mirabilos -- den AGP ste

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-15 Thread Luca Boccassi
On Wed, 15 Jan 2025 at 23:12, Sven Geuer wrote: > > On Wed, 2025-01-15 at 20:28 +0100, Thorsten Glaser wrote: > > On Wed, 15 Jan 2025, Sven Geuer wrote: > > > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504044#162 > > > > > Applying ExecCondition to me seems the most reasonable solutio

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-15 Thread Thorsten Glaser
On Thu, 16 Jan 2025, Sven Geuer wrote: >> If not, I’d lean towards one (which?) of the errorlevel-using ones, >> because otherwise we’d have to run the detection code twice. > >Not sure what you mean by 'one of the errorlevel-using ones'. Please >explain your idea in more details. SuccessExitStat

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-15 Thread Sven Geuer
On Wed, 2025-01-15 at 20:28 +0100, Thorsten Glaser wrote: > On Wed, 15 Jan 2025, Sven Geuer wrote: > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504044#162 > > > Applying ExecCondition to me seems the most reasonable solution to this > > bug. > > Can the script behind ExecCondition p

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-15 Thread Thorsten Glaser
On Wed, 15 Jan 2025, Sven Geuer wrote: >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504044#162 >Applying ExecCondition to me seems the most reasonable solution to this >bug. Can the script behind ExecCondition pass variables to the script behind ExecStart or, even better, the unit itself

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-15 Thread Sven Geuer
On Wed, 2025-01-15 at 00:47 +0100, Thorsten Glaser wrote: > On Tue, 14 Jan 2025, Luca Boccassi wrote: > > > It looks like this is doing some checks, and intends to skip. But just > > exiting means the service is recorded as failed, and this will likely > > trip other tests, hence the severity to s

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-14 Thread Thorsten Glaser
On Tue, 14 Jan 2025, Luca Boccassi wrote: >It looks like this is doing some checks, and intends to skip. But just >exiting means the service is recorded as failed, and this will likely >trip other tests, hence the severity to stop migrating to testing for >now. Ah, ouch. Agreed. >There are sever

Bug#1093002: rng-tools-debian: systemd service fails instead of skipping

2025-01-14 Thread Luca Boccassi
Package: rng-tools-debian Version: 2.5 Severity: grave Dear Maintainers, Thanks for adding a native systemd service! I noticed that in an autopkgtest-build-qemu VM the service fails: root@host:~# systemctl status --no-pager -l rng-tools-debian × rng-tools-debian.service - Hardware RNG entropy g