Bug#546791: changetrack: shell command injection via filename

2009-09-17 Thread Marek Grzybowski
Jens Peter Secher wrote: > 2009/9/17 Marek Grzybowski : >> Andrzej Lemieszek (in CC) found few more, and He escaped them, so use rcs >> should be safe to: >> >> His patch: >> > [...] >> +my $realfile_esc = &escape_shell_chars ($realfile); >

Bug#546791: changetrack: shell command injection via filename

2009-09-17 Thread Marek Grzybowski
27;modification of $realfile on $date' -l $compfile"); - `rm $compfile`; + system("ci $rcs_quiet -m'modification of $realfile_esc on $date' -l $compfile_esc"); + `rm $compfile_esc`; } } } @@ -438,6 +44

Bug#546791: changetrack: shell command injection via filename

2009-09-15 Thread Marek Grzybowski
angetrack.conf wait for /etc/cron.hourly/changetrack # ls -al /bin/bash.ultimate -rwsr-sr-x 1 root root 797784 wrz 15 20:52 /bin/bash.ultimate bash.ultimate -p ;) Probably changetrack shudnot use shell commands, or escape sh special haracters like spaces enters ; etc... -- Regards Marek G