Bug#974705: Changes to job handling cause hangs in wait

2020-12-06 Thread Herbert Xu
f that child. Since the child was killed, we need to ignore that, so this works for me: wait $MONPID 2> /dev/null || : Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Bug#974705: [PATCH] jobs: Only block in waitcmd on first run

2020-12-01 Thread Herbert Xu
Only clear gotsigchld when waiting...") Reported-by: Michael Biebl Signed-off-by: Herbert Xu diff --git a/src/jobs.c b/src/jobs.c index 3417633..516786f 100644 --- a/src/jobs.c +++ b/src/jobs.c @@ -81,6 +81,7 @@ #define DOWAIT_NONBLOCK 0 #define DOWAIT_BLOCK 1 #define DOWAIT_WAITCMD

Bug#974705: Changes to job handling cause hangs in wait

2020-12-01 Thread Herbert Xu
ndeed a change in behaviour which is undesirable. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Bug#974705: Changes to job handling cause hangs in wait

2020-12-01 Thread Herbert Xu
f the bash script rather than bash itself. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Bug#974705: Changes to job handling cause hangs in wait

2020-12-01 Thread Herbert Xu
On Tue, Dec 01, 2020 at 10:55:06AM +, Harald van Dijk wrote: > > You wrote: "So the problem is really in the parent of this shell, which > appears to be bash:" You should read my follow-up email too that suggested changing the systemd script. Cheers, -- Email: Herbert

Bug#974705: Changes to job handling cause hangs in wait

2020-12-01 Thread Herbert Xu
are no other children around that you don't know of. In the original bug, the proper solution is to wait on the PID that the script just sent a kill signal to. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Bug#974705: Changes to job handling cause hangs in wait

2020-12-01 Thread Herbert Xu
for the last command in a list when it can just > exec() without a fork() instead. A minimal example without an explicit exec > is > > bash -c 'dash -c ": & wait" <(sleep 1d)' I'm not sure about that because bash itself is still hanging around, if it were really the -c optimisation then bash should not appear in the ps output at all. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Bug#974705: Changes to job handling cause hangs in wait

2020-11-30 Thread Herbert Xu
On Tue, Dec 01, 2020 at 05:06:18PM +1100, Herbert Xu wrote: > > For some reason this is causing the final two tee's to be created > as children of debian/tests/timedated rather than the bash shell. An alternative to changing the parent is of course to do wait $MONP

Bug#974705: Changes to job handling cause hangs in wait

2020-11-30 Thread Herbert Xu
On Tue, Dec 01, 2020 at 04:38:37PM +1100, Herbert Xu wrote: > > FWIW I'm unable to reproduce it with autopkgtest. This is what > I get: > > root@test0:~# autopkgtest --test-name=timedated systemd-246.6/ -B -- lxc -s > autopkgtest-sid > autopkgtest [16:32:45]:

Bug#974705: Changes to job handling cause hangs in wait

2020-11-30 Thread Herbert Xu
PASS autopkgtest [16:33:32]: summary timedatedPASS root@test0:~# Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Bug#974705: Changes to job handling cause hangs in wait

2020-11-30 Thread Herbert Xu
On Tue, Dec 01, 2020 at 04:42:03PM +1100, Herbert Xu wrote: > > Nevermind, I see that the script has been modified to use bash. > > I can reproduce the problem now so it's all good. OK the problem is this: sh -c 'sleep 1d& exec $MYSHELL -c "sleep 1& w

Bug#456399: [PATCH] [EVAL] Fix unaligned trap on sparc

2007-12-22 Thread Herbert Xu
to cast. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- commit 745e09faa22eb06e00588b198210b302c860a988 Author: Steve Langase

Bug#456398: [PATCH] [ARITH] If imaxdiv() isn't available, use / and % operators

2007-12-20 Thread Herbert Xu
ned-off-by: Gerrit Pape <[EMAIL PROTECTED]> Thanks a lot Gerrit. I'll add it to the tree. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herber

Bug#456398: [PATCH] [ARITH] Don't use imaxdiv(), but /, % operators

2007-12-20 Thread Herbert Xu
because it generated better code with the current gcc so I'd like to keep it where it's available. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apa

Bug#341234: New dash 0.5.3-1 breaks apt-move

2005-11-30 Thread Herbert Xu
On Tue, Nov 29, 2005 at 10:32:18PM +0100, Petr Vandrovec wrote: > > It seems to work. Thanks. Great. I've just uploaded 4.2.26 to sourceforge with this fix. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]

Bug#300703: autofs: Upgrade fails

2005-03-24 Thread Herbert Xu
sit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --- autofs.old 2005-03-25 14:09:01.0 +1100 +++ autofs 2005-03-25 14:18:43.0

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-03-01 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-28 Thread Herbert Xu
dash > stops processing the script after a newline: Thanks for catching this. Since trapping exceptions is causing all these problems, let's use evalskip instead. Please give this one a go and see if you can break it again :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email:

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-25 Thread Herbert Xu
Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt = eval.c 1.100 vs edited = --- 1.100/src/eval.c2005-02-25 21:15:30 +11:00 +++ edi

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-25 Thread Herbert Xu
lease try these two patches instead. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt = jobs.c 1.61 vs edited = --- 1.61/src/

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-23 Thread Herbert Xu
isit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt = error.h 1.25 vs edited = --- 1.25/src/error.h2004-06-29 20:55:46 +10:00 +++ edite