Bug#956508: gitlab: webpack should build assets in production mode

2020-04-13 Thread Pirate Praveen
On 2020, ഏപ്രിൽ 12 7:50:04 PM IST, vv221 wrote: >On Sun, 12 Apr 2020 18:04:07 +0530 Pirate Praveen > wrote: >> On 2020, ഏപ്രിൽ 12 1:56:27 PM IST, vv221 >wrote: >> >I submitted a patch through salsa: >> >https://salsa.debian.org/ruby-team/gitlab/-/merge_requests/5 >> >> (…) >> >> I have merge

Bug#956508: gitlab: webpack should build assets in production mode

2020-04-12 Thread vv221
On Sun, 12 Apr 2020 18:04:07 +0530 Pirate Praveen wrote: > On 2020, ഏപ്രിൽ 12 1:56:27 PM IST, vv221 wrote: > >I submitted a patch through salsa: > >https://salsa.debian.org/ruby-team/gitlab/-/merge_requests/5 > > (…) > > I have merged your changes and I will upload it soon (after some testing).

Bug#956508: gitlab: webpack should build assets in production mode

2020-04-12 Thread Pirate Praveen
On 2020, ഏപ്രിൽ 12 1:56:27 PM IST, vv221 wrote: >I submitted a patch through salsa: >https://salsa.debian.org/ruby-team/gitlab/-/merge_requests/5 Thanks a lot! This brings significant improvement to the user experience. I have merged your changes and I will upload it soon (after some testing)

Bug#956508: gitlab: webpack should build assets in production mode

2020-04-12 Thread vv221
I submitted a patch through salsa: https://salsa.debian.org/ruby-team/gitlab/-/merge_requests/5 A copy of this patch it attached to this e-mail for convenience. From 9d95c466b0c26f8cecc3ff6d8a30d608e7a6cf88 Mon Sep 17 00:00:00 2001 From: vv221 Date: Sun, 12 Apr 2020 10:16:22 +0200 Subject: [PATCH

Bug#956508: gitlab: webpack should build assets in production mode

2020-04-12 Thread vv221
I think a side-effect of using production assets would be to fix https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927297 as it adds a unique hash to assets file names. The hash would be different after each GitLab upgrade, so there should no longer be cache issues for the GitLab instance users wh

Bug#956508: gitlab: webpack should build assets in production mode

2020-04-12 Thread vv221
Source: gitlab Version: 12.9.2-4 Severity: normal Current assets building through webpack is done by the following call set in /usr/lib/gitlab/scripts/rake-tasks.sh: runuser -u ${gitlab_user} -- sh -c 'NODE_OPTIONS="--max-old-space-size=2048" webpack --max-old-space-size=16384 --config config/we