Bug#945869: lintian: false positive for debian-rules-not-executable

2020-06-12 Thread Felix Lechner
Control: retitle -1 lintian: Ignore umask when recording file permissions in patched source tree Hi Andreas, On Sat, Nov 30, 2019 at 2:36 AM Andreas Metzler wrote: > > 0002. And surprisingly it does matter ;-) This is #796257 in Dpkg. Unfortunately, it has not been addressed in nearly five year

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-12-01 Thread gregor herrmann
On Sun, 01 Dec 2019 16:37:04 +, Chris Lamb wrote: > > N:The debian/rules file for this package does not appear to be marked as > > N:executable and should be changed to permission 0755. > > > > and the "0755" seems incorrect as well. > > Good spot. Updated in: > > https://salsa.de

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-12-01 Thread Chris Lamb
Hi gregor, > I think there's another tiny glitch left: The info for the tag says > > N:The debian/rules file for this package does not appear to be marked as > N:executable and should be changed to permission 0755. > > and the "0755" seems incorrect as well. Good spot. Updated in: h

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-12-01 Thread gregor herrmann
On Sun, 01 Dec 2019 09:35:50 +, Chris Lamb wrote: > > I also note that lib/Lintian/Path.pm has > > > > sub is_executable { return $_[0]->_any_bit_in_operm(0111); } > > Neat; applied and pending release. Thanks for the swift fix! I think there's another tiny glitch left: The info for the ta

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-12-01 Thread Chris Lamb
Hi gregor, > I also note that lib/Lintian/Path.pm has > > sub is_executable { return $_[0]->_any_bit_in_operm(0111); } Neat; applied and pending release. > [..] getting this message for each and every package I build gets > a bit boring It's surely a false positive rather than boring? :) Reg

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-30 Thread gregor herrmann
On Sun, 01 Dec 2019 12:30:00 +1100, Stuart Prescott wrote: > Checking that the file mode is exactly 0755 when all that is actually desired > is that the file be executable seems wrong. Ack, and getting this message for each and every package I build gets a bit boring ("my" debian/rules are 775 a

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-30 Thread Stuart Prescott
Checking that the file mode is exactly 0755 when all that is actually desired is that the file be executable seems wrong. checks/debian/rules.pm: # Check if debian/rules is marked as executable. $self->tag('debian-rules-not-executable') unless $rules->operm == 0755 or $rules->is_sym

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-30 Thread Andreas Metzler
On 2019-11-30 Felix Lechner wrote: > Hi Andreas, > I created the attached test case in Lintian, but I cannot get the tag > to show using '--pedantic': > $ frontend/lintian --pedantic > debian/test-out/packages/tags/checks/debian/rules/permissions-775/permissions-775_1.0.dsc > P: permissions-775

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-29 Thread Felix Lechner
Hi Andreas, I created the attached test case in Lintian, but I cannot get the tag to show using '--pedantic': $ frontend/lintian --pedantic debian/test-out/packages/tags/checks/debian/rules/permissions-775/permissions-775_1.0.dsc P: permissions-775 source: uses-debhelper-compat-file even though

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-29 Thread Andreas Metzler
On 2019-11-30 Felix Lechner wrote: > On Fri, Nov 29, 2019 at 9:48 PM Andreas Metzler wrote: >> -rwxrwxr-x 0/01277 2019-07-27 17:24 debian/rules > The check in Lintian here should perhaps use a bitwise 'and': > > https://salsa.debian.org/lintian/lintian/blob/master/checks/debia

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-29 Thread Felix Lechner
Hi Andreas, On Fri, Nov 29, 2019 at 9:48 PM Andreas Metzler wrote: > > -rwxrwxr-x 0/01277 2019-07-27 17:24 debian/rules The check in Lintian here should perhaps use a bitwise 'and': https://salsa.debian.org/lintian/lintian/blob/master/checks/debian/rules.pm#L174-176 Is there a

Bug#945869: lintian: false positive for debian-rules-not-executable

2019-11-29 Thread Andreas Metzler
Package: lintian Version: 2.39.0 Severity: normal Running lintian on libtasn1-6_4.14-3.dsc I get P: libtasn1-6 source: debian-rules-not-executable although the file is 775: ametzler@argenau:/tmp/TASN$ tar tvf libtasn1-6_4.14-3.debian.tar.xz | \ grep rules -rwxrwxr-x 0/01277 2