Hello,
On Mon 22 Jul 2019 at 02:15PM +01, Ian Jackson wrote:
> Unfortunately this has rather poor error handling.
> - In a common case (no d/patches) it will print an
> unwanted message to stderr
> - If git explodes for some other reason (ENOSPC) it will blunder on
>
> How about getting all
> > This seems like a very long way of writing a very short sed rune ?
>
> Now that there's only one while loop, I don't believe this comment
> applies.
I agree.
> In the revised series, I find the explicit -z check (l. 146) more
> readable than avoiding that check by means of sed. So I'd like
Hello,
On Sun 21 Jul 2019 at 06:05PM +01, Ian Jackson wrote:
> Sean Whitton writes ("Bug#932477: git-debpush checking that patches
> (un)apply"):
>> I've implemented this in branch 'series/git-debpush-apply-patches-v1' of
>> repo <https://git.spw
Hello,
On Sun 21 Jul 2019 at 04:25PM +01, Ian Jackson wrote:
> Sean Whitton writes ("Re: Bug#932477: git-debpush checking that patches
> (un)apply"):
>> I've implemented this in branch 'series/git-debpush-apply-patches-v1' of
>> repo <https://git.
Sean Whitton writes ("Bug#932477: git-debpush checking that patches (un)apply"):
> I've implemented this in branch 'series/git-debpush-apply-patches-v1' of
> repo <https://git.spwhitton.name/dgit>.
Hi. I've reviewed your substantive code. Looking rea
Ian Jackson writes ("Re: Bug#932477: git-debpush checking that patches
(un)apply"):
> The result is in salsa/wip.dpp. That's a rebase of your branch.
...
> FYI I intend to push to master everything up to and including
> salsa/wip. So don't rebase below there.
> The four tagupl tests pass if you hack the full path to
> git-playtree-create into the script -- it seems that using-intree has
> not been taught to make git-playtree-create available to git-debpush in
> the right way.
I have fixed this. I have also renamed git-playtree-create to
git-playtree-s
Re
git-debpush: check_treesame: Also pass --quiet to 'git diff'
When dgit fails for similar reasons we have it print a diffstat and
also print a git diff rune so that the user can see what has changed.
See near l.4598 in dgit. We probably don't want something that
sophisticated but maybe somet
Sean Whitton writes ("Re: Bug#932477: git-debpush checking that patches
(un)apply"):
> I've implemented this in branch 'series/git-debpush-apply-patches-v1' of
> repo <https://git.spwhitton.name/dgit>.
Thanks. Looking at it now.
I am folding your fixup
control: tag -1 +patch
Hello,
On Fri 19 Jul 2019 at 10:55PM +01, Ian Jackson wrote:
> It would be nice to check that the patches are right. (In
> gbp/unapplied, that they apply and are up to date.)
>
> This would involve git-apply, at the very least. Running gbp pq would
> add an unwanted depe
Package: git-debpush
Version: 9.3
It would be nice to check that the patches are right. (In
gbp/unapplied, that they apply and are up to date.)
This would involve git-apply, at the very least. Running gbp pq would
add an unwanted dependency and also it is very slow. The main
reason dgit and gd
11 matches
Mail list logo
