Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-25 Thread Adrian Bunk
On Tue, Jun 25, 2019 at 10:16:48AM +0200, Alberto Garcia wrote: > On Mon, Jun 24, 2019 at 04:48:43PM +0300, Alberto Garcia wrote: > > > If no one has anything to say I'll upload it today. This should work > > on all i386 CPUs, and we can later discuss if it's worth thinking of > > a solution for S

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-25 Thread Alberto Garcia
On Mon, Jun 24, 2019 at 04:48:43PM +0300, Alberto Garcia wrote: > If no one has anything to say I'll upload it today. This should work > on all i386 CPUs, and we can later discuss if it's worth thinking of > a solution for SSE2-capable machines. Uploaded, unblock request at #931052 I don't have

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-24 Thread Alberto Garcia
Control: tags -1 patch pending On Mon, Jun 24, 2019 at 10:29:56AM +0200, Alberto Garcia wrote: > 2) Build with SSE2 completely disabled (using WTF_CPU_UNKNOWN, or >somethig else, I'm still discussing this with the team). Ok, this patch disables SSE2 and forces Webkit to use CLoop, the C-based

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-24 Thread Adrian Bunk
On Mon, Jun 24, 2019 at 10:29:56AM +0200, Alberto Garcia wrote: > On Mon, Jun 24, 2019 at 12:34:26AM +0300, Adrian Bunk wrote: > > > > Building with SSE2 is not a decision made by the Debian > > > maintainers. Upstream WebKit dropped support for non-SSE2 > > > processors and the code assumes that

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-24 Thread Alberto Garcia
On Mon, Jun 24, 2019 at 12:34:26AM +0300, Adrian Bunk wrote: > > Building with SSE2 is not a decision made by the Debian > > maintainers. Upstream WebKit dropped support for non-SSE2 > > processors and the code assumes that SSE2 is always available: > > > >https://bugs.webkit.org/show_bug.cg

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-23 Thread Adrian Bunk
Control: tags -1 -patch Looking again at the code it seems my patch is actually wrong, and wonder whether WTF_CPU_UNKNOWN might be the correct approach. On Sun, Jun 23, 2019 at 10:23:41PM +0200, Alberto Garcia wrote: > > Building with SSE2 is not a decision made by the Debian maintainers. > Upst

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-23 Thread Alberto Garcia
On Sat, Jun 22, 2019 at 10:40:53PM +0300, Adrian Bunk wrote: > Fix is attached. Building with SSE2 is not a decision made by the Debian maintainers. Upstream WebKit dropped support for non-SSE2 processors and the code assumes that SSE2 is always available: https://bugs.webkit.org/show_bug.cgi

Bug#930935: webkit2gtk: Baseline violation on i386

2019-06-22 Thread Adrian Bunk
Source: webkit2gtk Version: 2.24.1-2 Severity: serious Tags: patch webkit2gtk violates the baseline on i386 by using SSE. While keeping floating point values consistent between 32bit and 64bit is nice in general, it is bad if this makes the code crash on large parts of the supported i386 hardware