Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-07 Thread Brad King
On 12/7/18 7:44 AM, Jochen Sprickerhof wrote: >> Both are valid ways to link to the pthread library, which is all >> the `-pthread` flag does when used to drive linking. > > I don't agree. Quoting from my mail: > > "Define additional macros required" Macros are for compiling. It is not used dur

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-07 Thread Jochen Sprickerhof
* Brad King [2018-12-07 07:29]: On 12/6/18 4:16 PM, Jochen Sprickerhof wrote: after reading up on this, I think this needs fixing in cmake. So neither adding -lpthread, nor adding /usr/lib/x86_64-linux-gnu/libpthread.so seems correct to me. Both are valid ways to link to the pthread library,

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-07 Thread Brad King
On 12/6/18 4:16 PM, Jochen Sprickerhof wrote: > after reading up on this, I think this needs fixing in cmake. > > So neither adding -lpthread, > nor adding /usr/lib/x86_64-linux-gnu/libpthread.so > seems correct to me. Both are valid ways to link to the pthread library, which is all the `-pthread

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-06 Thread Jochen Sprickerhof
control: reopen -1 control: reassign -1 src:cmake control: affects -1 ros-ros-comm control: tags -1 - patch Hi, after reading up on this, I think this needs fixing in cmake. man gcc: | -pthread | | Define additional macros required for using the POSIX threads | library. You should use this

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-05 Thread Jochen Sprickerhof
Hi Gianfranco, * Gianfranco Costamagna [2018-12-05 10:36]: catkin upstream would prefer to add -pthread instead of -lpthread to the compiler flags. See the discussion here: https://github.com/ros/catkin/issues/856 Would this be possible? what about: | elseif(${library} MATCHES "^-l")

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-05 Thread Gianfranco Costamagna
>catkin upstream would prefer to add -pthread instead of -lpthread to the >compiler flags. See the discussion here: > >https://github.com/ros/catkin/issues/856 > >Would this be possible? what about: | elseif(${library} MATCHES "^-l") | | list(APPEND @PROJECT_NAME@_LIBRARIES ${library})

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-02 Thread Jochen Sprickerhof
Hi Felix, catkin upstream would prefer to add -pthread instead of -lpthread to the compiler flags. See the discussion here: https://github.com/ros/catkin/issues/856 Would this be possible? Cheers Jochen * Jochen Sprickerhof [2018-12-02 14:59]: Hi, makes sense to me, I uploaded -8 with th

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-02 Thread Jochen Sprickerhof
Hi, makes sense to me, I uploaded -8 with the patch and send it upstream: https://github.com/ros/catkin/pull/975 Thank for it Felix. Cheers Jochen signature.asc Description: PGP signature

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-01 Thread Gianfranco Costamagna
control: reassign -1 src:ros-catkincontrol: found -1 0.7.14-7control: tags -1 patch Hello, >Adding something like this would probably fix it: >>   elseif(${library} MATCHES "^-l") >>     list(APPEND @PROJECT_NAME@_LIBRARIES ${library}) > >CCing Brad, maybe you could comment if ros-catkin should e

Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

2018-12-01 Thread Felix Geyer
Hi, On 01.12.18 06:31, Gianfranco Costamagna wrote: Package: cmake Version: 3.13.1-1 Severity: serious Affects: ros-ros-comm A simple ros-ros-comm rebuild now fails with the new cmake in unstable, due to lpthread not being found as target. I don't know if catkin is to blame, or something else,

Bug#915148: cmake: regression in ros-ros-comm build

2018-11-30 Thread Gianfranco Costamagna
control: affects -1 ros-ros-comm control: notfound -1 3.12.3-3 fixing tags. G.