Bug#913274: Changing the _is_real_file() function

2019-01-07 Thread Stuart Prescott
Hi Colin, Many thanks for the additional information about how python-apt has changed and for looking over this change. It is much appreciated. > I might be inclined to suggest renaming _is_real_file, since its name is > a little misleading now. Maybe _has_fileno? Yes, that sounds like a very

Bug#913274: Changing the _is_real_file() function

2019-01-04 Thread Colin Watson
On Mon, Dec 31, 2018 at 07:45:52PM +1100, Stuart Prescott wrote: > Many years ago in doing the Python 2→3 port for python-debian, you wrote a > function to guard against giving file-like objects that were not file > handles to apt_pkg [1]. The reason I've been looking at this today is that > the c

Bug#913274: Changing the _is_real_file() function

2018-12-31 Thread Stuart Prescott
Hi Colin, Many years ago in doing the Python 2→3 port for python-debian, you wrote a function to guard against giving file-like objects that were not file handles to apt_pkg [1]. The reason I've been looking at this today is that the current check incorrectly identifies NamedTemporaryFile as not