Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-27 Thread Michael Hudson-Doyle
LGTM On Mon, 27 Aug 2018 at 16:06, Shengjing Zhu wrote: > On Mon, Aug 27, 2018 at 10:03:57AM +1200, Michael Hudson-Doyle wrote: > > It's available in go list as well, e.g. > > > > $ go list -f '{{if not .Standard}}{{ .ImportPath }}{{end}}' > > github.com/snapcore/snapd/snap bytes > > github.com/

Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Shengjing Zhu
On Mon, Aug 27, 2018 at 10:03:57AM +1200, Michael Hudson-Doyle wrote: > It's available in go list as well, e.g. > > $ go list -f '{{if not .Standard}}{{ .ImportPath }}{{end}}' > github.com/snapcore/snapd/snap bytes > github.com/snapcore/snapd/snap > $ That's much simpler, so the second patch is a

Bug#907263: [pkg-go] Bug#907263: Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Michael Hudson-Doyle
It's available in go list as well, e.g. $ go list -f '{{if not .Standard}}{{ .ImportPath }}{{end}}' github.com/snapcore/snapd/snap bytes github.com/snapcore/snapd/snap $ Cheers, mwh On Mon, 27 Aug 2018 at 03:33, Michael Stapelberg wrote: > There is a way, dh-make-golang does it: > https://gith

Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Michael Stapelberg
If that’s required to fix the bug, then so be it :) On Sun, Aug 26, 2018 at 5:52 PM, Shengjing Zhu wrote: > On Sun, Aug 26, 2018 at 11:33 PM Michael Stapelberg > wrote: > > > > There is a way, dh-make-golang does it: https://github.com/Debian/dh- > make-golang/blob/f0afc0f7169eb4f261449d8c4bd6f

Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Shengjing Zhu
On Sun, Aug 26, 2018 at 11:33 PM Michael Stapelberg wrote: > > There is a way, dh-make-golang does it: > https://github.com/Debian/dh-make-golang/blob/f0afc0f7169eb4f261449d8c4bd6fc7950583617/make.go#L177-L192 > Thanks for this info, first time to know `go list std` usage. However if we go with

Bug#907263: [pkg-go] Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Michael Stapelberg
There is a way, dh-make-golang does it: https://github.com/Debian/dh-make-golang/blob/f0afc0f7169eb4f261449d8c4bd6fc7950583617/make.go#L177-L192 On Sun, Aug 26, 2018 at 12:34 PM, Shengjing Zhu wrote: > On Sun, Aug 26, 2018 at 5:44 PM Michael Hudson-Doyle > wrote: > > > > I've forgotten everythi

Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Shengjing Zhu
On Sun, Aug 26, 2018 at 5:44 PM Michael Hudson-Doyle wrote: > > I've forgotten everything about this code even though I wrote it, but > wouldn't it be better to filter out the standard library dependencies? > For golang-go, currently it uses std library to producing the Built-Using for golang-go

Bug#907263: [pkg-go] Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-26 Thread Michael Hudson-Doyle
I've forgotten everything about this code even though I wrote it, but wouldn't it be better to filter out the standard library dependencies? On Sun, 26 Aug 2018 at 04:03, Shengjing Zhu wrote: > Package: dh-golang > Severity: important > Tags: patch > > Dear Maintainer, > > dh-golang failed to bu

Bug#907263: dh-golang: Failed to build with gccgo-8

2018-08-25 Thread Shengjing Zhu
Package: dh-golang Severity: important Tags: patch Dear Maintainer, dh-golang failed to build with gccgo-8. dh_golang -O--buildsystem=golang "go list -f '{{ range .Deps }}{{.}}\ {{ end }}'" github.com/elves/elvish [...] "go list -f '\\\ {{ .Dir }}/{{ index (or .GoFiles .CgoFil