Bug#854658: unblock pre-approval request for gitlab

2017-03-17 Thread Pirate Praveen
On 2017, മാർച്ച് 16 11:40:20 PM IST, Andreas Beckmann wrote: >why can't you post the *CORRECT* debdiff? > >The diff between -4 and -5 as found in the archive looks much better >and >should actually fix the issue ... Sorry about that, I didn't realize the -4 dsc file included some local changes

Bug#854658: unblock pre-approval request for gitlab

2017-03-16 Thread Andreas Beckmann
Pirate, On 2017-03-14 14:26, Pirate Praveen wrote: > #856606 was introduced by gitlab 8.13.11+dfsg-4, which is now fixed in > 8.13.11+dfsg-5. Please unblock. why can't you post the *CORRECT* debdiff? The diff between -4 and -5 as found in the archive looks much better and should actually fix th

Bug#854658: unblock pre-approval request for gitlab

2017-03-16 Thread Andreas Beckmann
On 2017-03-16 09:37, Emilio Pozuelo Monfort wrote: > On 15/03/17 15:53, Andreas Beckmann wrote: >> On 2017-03-14 14:26, Pirate Praveen wrote: >>> #856606 was introduced by gitlab 8.13.11+dfsg-4, which is now fixed in >>> 8.13.11+dfsg-5. Please unblock. >> >> I'm pretty sure this is *not* a proper

Bug#854658: unblock pre-approval request for gitlab

2017-03-16 Thread Emilio Pozuelo Monfort
On 15/03/17 15:53, Andreas Beckmann wrote: > On 2017-03-14 14:26, Pirate Praveen wrote: >> #856606 was introduced by gitlab 8.13.11+dfsg-4, which is now fixed in >> 8.13.11+dfsg-5. Please unblock. > > I'm pretty sure this is *not* a proper fix, Can you elaborate? Why is the fix not right? And ev

Bug#854658: unblock pre-approval request for gitlab

2017-03-15 Thread Andreas Beckmann
On 2017-03-14 14:26, Pirate Praveen wrote: > #856606 was introduced by gitlab 8.13.11+dfsg-4, which is now fixed in > 8.13.11+dfsg-5. Please unblock. I'm pretty sure this is *not* a proper fix, but gitlab has now become uninstallable in stretch after gitlab-shell migrated, because gitlab-shell m

Bug#854658: unblock pre-approval request for gitlab

2017-03-14 Thread Pirate Praveen
Control: reopen -1 On ശനി 04 മാര്‍ച്ച് 2017 02:33 വൈകു, Niels Thykier wrote: > Unblocked, thanks. > ~Niels #856606 was introduced by gitlab 8.13.11+dfsg-4, which is now fixed in 8.13.11+dfsg-5. Please unblock. diff -Nru gitlab-8.13.11+dfsg/debian/changelog gitlab-8.13.11+dfsg/debian/changelog

Bug#854658: unblock pre-approval request for gitlab

2017-03-02 Thread Pirate Praveen
On ശനി 25 ഫെബ്രുവരി 2017 11:03 രാവിലെ, Pirate Praveen wrote: > Attaching the source debdiffs. > ping signature.asc Description: OpenPGP digital signature

Bug#854658: unblock pre-approval request for gitlab

2017-02-24 Thread Pirate Praveen
On വെള്ളി 24 ഫെബ്രുവരി 2017 08:19 വൈകു, Balasankar C wrote: > Should I share the source debdiff of both these uploads to this issue or is a > separate issue necessary for gitlab-shell (The change is exactly the one > mentioned for gitlab. Not using /usr/share/gitlab-shell/doc ) ? > Attaching the so

Bug#854658: unblock pre-approval request for gitlab

2017-02-24 Thread Balasankar C
Hi, On Mon, 20 Feb 2017 18:26:00 + Niels Thykier wrote: > > FYI, I have retracted the hint until this issue has been resolved (to > avoid a possible regression in testing). > > Thanks, > ~Niels Latest upload of gitlab (version: 8.13.11+dfsg-4) and gitlab-shell (version 3.6.6-4) fixes the

Bug#854658: unblock pre-approval request for gitlab

2017-02-20 Thread Niels Thykier
Control: reopen -1 Andreas Beckmann: > On 2017-02-20 11:03, Pirate Praveen wrote: >> On ഞായര്‍ 19 ഫെബ്രുവരി 2017 02:17 വൈകു, Andreas Beckmann wrote: >>> Policy 12.3: "Packages must not require the existence of any >>> files in /usr/share/doc/ in order to function." > >> but /usr/share/gitlab is u

Bug#854658: unblock pre-approval request for gitlab

2017-02-20 Thread Andreas Beckmann
On 2017-02-20 11:03, Pirate Praveen wrote: > On ഞായര്‍ 19 ഫെബ്രുവരി 2017 02:17 വൈകു, Andreas Beckmann wrote: >> Policy 12.3: "Packages must not require the existence of any >> files in /usr/share/doc/ in order to function." > but /usr/share/gitlab is upstream files and I'm reluctant to add these >

Bug#854658: unblock pre-approval request for gitlab

2017-02-20 Thread Pirate Praveen
On ഞായര്‍ 19 ഫെബ്രുവരി 2017 02:17 വൈകു, Andreas Beckmann wrote: > On Fri, 17 Feb 2017 12:24:53 +0530 Pirate Praveen wrote: >> +gitlab_tmpfiles_example=/usr/share/doc/gitlab/tmpfiles.d/gitlab.conf.example > If this file gets used from the maintainer scripts, > it must be moved to /usr/share/gitlab

Bug#854658: unblock pre-approval request for gitlab

2017-02-19 Thread Andreas Beckmann
On Fri, 17 Feb 2017 12:24:53 +0530 Pirate Praveen wrote: > +gitlab_tmpfiles_example=/usr/share/doc/gitlab/tmpfiles.d/gitlab.conf.example If this file gets used from the maintainer scripts, it must be moved to /usr/share/gitlab instead, see Policy 12.3: "Packages must not require the existence of

Bug#854658: unblock pre-approval request for gitlab

2017-02-18 Thread Pirate Praveen
On വെള്ളി 17 ഫെബ്രുവരി 2017 12:24 വൈകു, Pirate Praveen wrote: > Attaching the debdiff (I'll upload it once current version in unstable > migrates to testing). gitlab 8.13.11+dfsg-3 is in unstable now. signature.asc Description: OpenPGP digital signature

Bug#854658: unblock pre-approval request for gitlab

2017-02-16 Thread Pirate Praveen
On ഞായര്‍ 12 ഫെബ്രുവരി 2017 12:24 രാവിലെ, Niels Thykier wrote: > The two patches in the bug looks ok; assuming only a changelog entry on > top of that, then it is a approved. > > For future requests: Could you please provide a source debdiff? It makes > it easier for us for us to figure out what wi

Bug#854658: unblock pre-approval request for gitlab

2017-02-11 Thread Niels Thykier
Control: tags -1 confirmed Praveen Arimbrathodiyil: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > Control: block 854617 by -1 > > I'd like to make gitlab user configurable as requested in > #854617. This will be helpful for p

Bug#854658: unblock pre-approval request for gitlab

2017-02-08 Thread Praveen Arimbrathodiyil
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Control: block 854617 by -1 I'd like to make gitlab user configurable as requested in #854617. This will be helpful for people who want to mi