Control: tag -1 pending
On Wed, Oct 26, 2016 at 10:52:29AM +, Daniel Shahaf wrote:
> Mattia Rizzolo wrote on Sun, Oct 23, 2016 at 23:21:53 +:
> > Though I'd really prefer to see some tests for this before applying it;
>
> Attached.
>
> The code change is unchanged from the previous patch
Mattia Rizzolo wrote on Sun, Oct 23, 2016 at 23:21:53 +:
> Though I'd really prefer to see some tests for this before applying it;
Attached.
The code change is unchanged from the previous patch.
Test test works; I'm not sure whether is idiomatic pytest, though.
Cheers
Daniel
[[[
diff --g
Mattia Rizzolo wrote on Sun, Oct 23, 2016 at 23:21:53 +:
> On Sat, Oct 01, 2016 at 06:06:38PM +, Daniel Shahaf wrote:
> > It passes the existing test suite, but I haven't yet tried writing
> > a unit test for this.
>
> It looks cool to me.
Thanks.
> Though I'd really prefer to see some t
On Sun, Oct 02, 2016 at 04:55:37PM +, Daniel Shahaf wrote:
> HW42 wrote on Sat, Oct 01, 2016 at 17:39:00 +:
> > Daniel Shahaf:
> > > It would be better to report "json files are equal up to order of
> > > elements in an object (= hash, dictionary, associative array)", and to
> > > print the
On Sat, Oct 01, 2016 at 06:06:38PM +, Daniel Shahaf wrote:
> It passes the existing test suite, but I haven't yet tried writing
> a unit test for this.
It looks cool to me.
Though I'd really prefer to see some tests for this before applying it;
do you think you can work on some?
--
regards,
HW42 wrote on Sat, Oct 01, 2016 at 17:39:00 +:
> Daniel Shahaf:
> > It would be better to report "json files are equal up to order of
> > elements in an object (= hash, dictionary, associative array)", and to
> > print the difference in a more readable way than a hex dump. (For
> > example, a
Daniel Shahaf:
> It would be better to report "json files are equal up to order of
> elements in an object (= hash, dictionary, associative array)", and to
> print the difference in a more readable way than a hex dump. (For
> example, a linewise diff of pretty-printed json.)
While at it, it shoul
Control: tags -1 patch
Daniel Shahaf wrote on Sat, Oct 01, 2016 at 17:23:42 +:
> It would be better to report "json files are equal up to order of
> elements in an object (= hash, dictionary, associative array)", and to
> print the difference in a more readable way than a hex dump. (For
> exa
Source: diffoscope
Version: 60
Severity: wishlist
Tags: upstream
Dear Maintainer,
When two json files differ only in order of elements, diffoscope falls
back to binary comparison:
[[[
% head -999 /tmp/?.json
==> /tmp/1.json <==
{
"hello": 42,
"world": 43
}
==> /tmp/2.json <==
{
"world": 4
9 matches
Mail list logo
