retitle 835641 diffoscope: tracebacks when comparing directories to
non-directories
thanks
This is actually bigger than just dangling symlinks:
$ diffoscope /etc/cron.d/ /etc/fstab --no-progress
cmp: /etc/cron.d/: Is a directory
Traceback (most recent call last):
File "/usr/lib/python3/dist-pa
tags 835641 - patch
thanks
Hi Brett,
Thanks for sending this patch and sorry its taken us so long to get to
it.
However, I don't think its quite ready in the sense that it only captures
the case where specify such files on the command line, rather than within
the entirity of diffoscope.
In othe
Here's a patch to prevent the traceback. It just detects the general
situation (comparing a directory with something else) and bails with a
more helpful message when they're incompatible.
I checked what diff does, and it does something slightly more nuanced:
if you compare directory D against non
Also dir to real file:
On Sat, Aug 27, 2016 at 10:51:49PM +0100, Chris Lamb wrote:
> $ mkdir dir
>
> $ ln -sf dst-file src-file
>
> $ diffoscope dir src-file
> cmp: dir: Is a directory
[..]
> Traceback (most recent call last):
> File "/usr/lib/python3/dist-packages/diffoscope/difference.py",
Package: diffoscope
Version: 59
Severity: normal
$ mkdir dir
$ ln -sf dst-file src-file
$ diffoscope dir src-file
cmp: dir: Is a directory
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 200, in main
sys.exit(run_diffoscope(parsed_args))
5 matches
Mail list logo