Bug#809334: [Pkg-iscsi-maintainers] Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Christian Seiler
Control: tags -1 + pending On 02/07/2016 11:56 AM, Ritesh Raj Sarraf wrote: > On Sun, 2016-02-07 at 11:39 +0100, Christian Seiler wrote: >> That's not so great. >> >> I looked at the source code of logout-all.sh again found >> the mistake: when reading in /run/o-i/s-k-s, it would just use >> XXX=$

Bug#809320: [Pkg-iscsi-maintainers] Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Ritesh Raj Sarraf
On Sun, 2016-02-07 at 11:39 +0100, Christian Seiler wrote: > That's not so great. > > I looked at the source code of logout-all.sh again found > the mistake: when reading in /run/o-i/s-k-s, it would just use > XXX=$(cat /run/o-i/s-k-s) > But to then check whether a session was excluded, it would u

Bug#809334: [Pkg-iscsi-maintainers] Bug#809334: Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Christian Seiler
On 02/07/2016 11:38 AM, Ritesh Raj Sarraf wrote: > On Sun, 2016-02-07 at 15:11 +0530, Ritesh Raj Sarraf wrote: >> >> root@debian-sanboot:~# systemctl stop open-iscsi >> >> root@debian-sanboot:~# cat /run/open-iscsi/shutdown-keep-sessions >> /sys/devices/platform/host2/session1 >> /sys/devices/plat

Bug#809320: [Pkg-iscsi-maintainers] Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Christian Seiler
Hi Ritesh, On 02/07/2016 10:41 AM, Ritesh Raj Sarraf wrote: > Looks like this invocation is problematic > > root@debian-sanboot:~# /lib/open-iscsi/umountiscsi.sh > ls: cannot access /dev/sda?*: No such file or directory > ls: cannot access /dev/sdb?*: No such file or directory > ls: cannot

Bug#809320: [Pkg-iscsi-maintainers] Bug#809334: Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Ritesh Raj Sarraf
On Sun, 2016-02-07 at 15:11 +0530, Ritesh Raj Sarraf wrote: > > root@debian-sanboot:~# systemctl stop open-iscsi > > root@debian-sanboot:~# cat /run/open-iscsi/shutdown-keep-sessions  > /sys/devices/platform/host2/session1 > /sys/devices/platform/host3/session2 > /sys/devices/platform/host4/sessi

Bug#809320: [Pkg-iscsi-maintainers] Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Ritesh Raj Sarraf
On Wed, 2015-12-30 at 13:34 +0100, Christian Seiler wrote: > On 12/30/2015 12:35 PM, Ritesh Raj Sarraf wrote: > > But the change you've proposed has other repercussion. It breaks > > shutdown, because now, iscsi service/sessions are terminated way > > early. > > This leaves, effectively, a hung san

Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-02-07 Thread Ritesh Raj Sarraf
On Sun, 2016-01-31 at 19:16 +0100, Christian Seiler wrote: > On 12/30/2015 12:13 PM, Christian Seiler wrote: > > Well, that would not be ideal, obviously. But if we propagate the > > error and just ignore 15 (already logged in) then we'll have the > > case that some portals will be in the logged-in

Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2016-01-31 Thread Christian Seiler
Hi Ritesh, On 12/30/2015 12:13 PM, Christian Seiler wrote: > Well, that would not be ideal, obviously. But if we propagate the > error and just ignore 15 (already logged in) then we'll have the > case that some portals will be in the logged-in state and others > might not; and if systemd thinks th

Bug#809320: [Pkg-iscsi-maintainers] Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2015-12-30 Thread Christian Seiler
On 12/30/2015 12:35 PM, Ritesh Raj Sarraf wrote: > But the change you've proposed has other repercussion. It breaks > shutdown, because now, iscsi service/sessions are terminated way early. > This leaves, effectively, a hung sanboot system. > > Please see attached images. > > I also didn't like t

Bug#809320: Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2015-12-30 Thread Ritesh Raj Sarraf
But the change you've proposed has other repercussion. It breaks shutdown, because now, iscsi service/sessions are terminated way early. This leaves, effectively, a hung sanboot system. Please see attached images. I also didn't like that iscsi shutdown, even thought my rootfs was running. I'll k

Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2015-12-30 Thread Christian Seiler
Hi Ritesh, On 12/30/2015 10:56 AM, Ritesh Raj Sarraf wrote: >> So one solution could be to use SuccessExitStatus=0 15 in the unit to >> say that 'already logged in' is not an error condition (and possibly >> others, I'd have to check the manpage) - but I think that is >> short-sighted, as this wil

Bug#809320: Bug#809334: Bug#809320: open-iscsi: no session termination on stop

2015-12-30 Thread Ritesh Raj Sarraf
Hello Christian, On Tue, 2015-12-29 at 18:43 +0100, Christian Seiler wrote: > I have been trying to play around with my VM setup, to build an > > iSCSI > > SAN Boot Setup. In doing that, I noticed something odd. Perhaps you > > may > > have some pointers. > > > > root@debian-sanboot:~# /etc/init.

Bug#809320: open-iscsi: no session termination on stop

2015-12-29 Thread Christian Seiler
Control: merge 809320 809334 Control: tags 809320 + confirmed Hi Ritesh, On 12/29/2015 11:47 AM, Ritesh Raj Sarraf wrote: > Hope you are doing good. And wish you belated Christman and a coming > Happy New Year. :-) Thanks, you as well. :) Unfortunately, I'm a bit busy right now until the 16th o

Bug#809320: open-iscsi: no session termination on stop

2015-12-29 Thread Ritesh Raj Sarraf
Package: open-iscsi Severity: important Hello Christian, Hope you are doing good. And wish you belated Christman and a coming Happy New Year. :-) I have been trying to play around with my VM setup, to build an iSCSI SAN Boot Setup. In doing that, I noticed something odd. Perhaps you may have so