Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-12-09 Thread Gianfranco Costamagna
Hi i don't see any problem here https://buildd.debian.org/status/package.php?p=liblastfm&suite=unstable But if you have a fixed package feel free to ping me and i'll have a look(I'm not a symbols - savvy man) Cheers, G Sent from Yahoo Mail on Android On Wed, 9 Dec, 2015 at 21:09, Stefan Ahle

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-12-09 Thread Stefan Ahlers
Hi, Thanks for signing and uploading! > Note: I removed the "debian/liblastfm*.new", because it was useless in > the context. > > I also tried to mv the .new in the original and correct location, but > the build failed with a gensybols error. > > so I just removed it and signed&uploaded. This

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-20 Thread Stefan Ahlers
Hi, I've uploaded a new version to mentors.debian.net > sure, I built for the last missing archs: > http://debomatic-powerpc.debian.net/distribution#unstable/liblastfm/1.0.9-1/buildlog > http://debomatic-s390x.debian.net/distribution#unstable/liblastfm/1.0.9-1/buildlog Thanks for building, but it

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-19 Thread Gianfranco Costamagna
Hi Stefan, >yes, the question actually is why one is liblastfm1 and the other >liblastfm5-1(I mean the -1, but it isn't a real problem I guess) >On Qt4 build the library so-name is liblastfm.so.1 and the package > scheme is: → liblastfm1 >For the Qt5 build the name is liblastfm5.so.1 and the

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-19 Thread Stefan Ahlers
Hi, > yes, the question actually is why one is liblastfm1 and the other > liblastfm5-1(I mean the -1, but it isn't a real problem I guess) On Qt4 build the library so-name is liblastfm.so.1 and the package scheme is: ** → liblastfm1 For the Qt5 build the name is liblastfm5.so.1 and the scheme i

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-19 Thread Gianfranco Costamagna
Hi, >Fixed! I've set up a new repository. wonderful >Oha, this is great. Now the symbols are human readable. :) >liblastfm1 is build against Qt4 and liblastfm5-1 is build against Qt5. >I've adopt the names of lintian. yes, the question actually is why one is liblastfm1 and the other libl

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-19 Thread Paul Wise
On Thu, 2015-11-19 at 12:05 +0100, Stefan Ahlers wrote: > In which case I should add UpstreamMetadatas into the package? Whenever there is an upstream where you can fill in any of the fields listed on the UpstreamMetadata wiki page. > Is it a "nice to have" feature or in some cases necessary? I

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-19 Thread Stefan Ahlers
Paul Wise wrotes: > If the wiki page isn't clear enough, try the examples: > https://wiki.debian.org/UpstreamMetadata#Examples Sorry my question was wrong. In which case I should add UpstreamMetadatas into the package? Is it a "nice to have" feature or in some cases necessary? For me it looks lik

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-18 Thread Paul Wise
On Thu, Nov 19, 2015 at 1:06 AM, Stefan Ahlers wrote: > I'm not sure what I have to add for upstream metadatas If the wiki page isn't clear enough, try the examples: https://wiki.debian.org/UpstreamMetadata#Examples > I do not know what to do with the output of > > flawfinder -Q -c . I would j

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-18 Thread Stefan Ahlers
Hi, > 1) VCS-* they should point to Debian packaging, not to upstream packaging > (this is done in copyright) Fixed! I've set up a new repository. > 2) symbols: > sed 's/ \(_.*\) \(.*\)/ (c++)"\1" \2/' package.symbols | c++filt > > package.symbols.new > > and look to the "new" file :) > (you might

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-18 Thread Gianfranco Costamagna
Hi, >I tried to fix most of the points. I replaced my patch with a applied >upstream patch. One of the symbol files had a wrong file name. This >should be fixed, too. lets see :) 1) VCS-* they should point to Debian packaging, not to upstream packaging (this is done in copyright) 2) symbols: s

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-18 Thread Stefan Ahlers
Hi, I tried to fix most of the points. I replaced my patch with a applied upstream patch. One of the symbol files had a wrong file name. This should be fixed, too. I'm not sure what I have to add for upstream metadatas and I do not know what to do with the output of flawfinder -Q -c . Please l

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-18 Thread Gianfranco Costamagna
Control: owner -1 ! Control: tags -1 moreinfo Hi Stefan (some issues of libjdns also apply here, and Pabs review is correct, so please check them before) in additions: please consider moving priority to optional https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities the other

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-18 Thread Paul Wise
On Wed, Nov 18, 2015 at 12:58 AM, Stefan Ahlers wrote: > I am looking for a sponsor for my package "liblastfm" I don't intend to sponsor this package, but here is a review: There don't appear to be any blockers. These things would be nice to fix: Please put DEP-3 a header on the patch. http:/

Bug#805393: Subject: RFS: liblastfm/1.0.9-1 [ITA]

2015-11-17 Thread Stefan Ahlers
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "liblastfm" * Package name: liblastfm Version : 1.0.9-1 Upstream Author : Michael Coffey * URL : https://github.com/lastfm/liblastfm * License : GPL-3+ Se