>Done as well. I am not sure though what is the difference..
none I guess, just looking better, and $(MAKE) might not always point to
"make" command
another issue:
"./docs/_themes/LICENSE"
please check it and mention in the copyright file
debian/copyright: please use BSD-3-clause standard sy
Hello,
Thanks again. I've fixed the issues and added a patch for the privacy breach
On 10/23/2015 04:34 PM, Gianfranco Costamagna wrote:
> and now something more important:
> 2) override_dh_auto_clean:
> dh_auto_clean
>
> this is absolutely useless :)
>
Yes i forgot to add the line to re
Hi, some final nitpicks:
1) please avoid double "\n" when possible.
e.g. copyright lines 9-10
rules lines 6-7
(control file, various parts)
and now something more important:
2) override_dh_auto_clean:
dh_auto_clean
this is absolutely useless :)
3) "cd docs && make html"
please consider
Hello,
Many thanks for the review
On 10/23/2015 01:19 PM, Gianfranco Costamagna wrote:
> Hi,
>
> first sorry for the long time for the review
>
> let's review:
>
> a) control: Priority:optional
> b) rules: please remove lines 3-4
> c) control: please add a -doc package
> (you can take some
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Control: owner -1 !
Control: tags -1 moreinfo
Hi,
first sorry for the long time for the review
let's review:
a) control: Priority:optional
b) rules: please remove lines 3-4
c) control: please add a -doc package
(you can take some bits from pyth
5 matches
Mail list logo