Bug#763540: Review of psocksxx/0.0.5-1

2014-10-04 Thread Jörg Frings-Fürst
Hello, I have uploaded[1] a new version including the new upstream release. CU Jörg [1] http://mentors.debian.net/debian/pool/main/p/psocksxx/psocksxx_0.0.6-1.dsc -- pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E pgp Key: BE581B6E CAcert Key S/N: 0E:D4:56 Jörg Frings-Für

Bug#763540: Review of psocksxx/0.0.5-1

2014-10-03 Thread Paul Wise
On Fri, 2014-10-03 at 13:36 +0200, Jörg Frings-Fürst wrote: > New package is uploaded to mentors[1]. The package looks good to me. I don't have time for sponsorship but I would encourage the regular sponsors on debian-mentors to upload this. > The reason is that I want use GPL-3+ for my work. Bu

Bug#763540: Review of psocksxx/0.0.5-1

2014-10-03 Thread Jörg Frings-Fürst
Hello Paul, Hello Harlan, thanks for the review. Am Mittwoch, den 01.10.2014, 12:50 +0800 schrieb Paul Wise: > On Wed, Oct 1, 2014 at 10:18 AM, Harlan Lieberman-Berg wrote: > [...] > Some more minor issues that you might want to fix at some point: > > The build process doesn't include -Wall in

Bug#763540: Review of psocksxx/0.0.5-1

2014-09-30 Thread Paul Wise
On Wed, Oct 1, 2014 at 10:18 AM, Harlan Lieberman-Berg wrote: > I took a look at psocksxx, and it looks pretty good! Agreed, good review Harlan! > A couple minor things that need to be changed: Agreed with both of these. Some more minor issues that you might want to fix at some point: The bui

Bug#763540: Review of psocksxx/0.0.5-1

2014-09-30 Thread Jörg Frings-Fürst
Hello Harlan, first thanks for reviewing psocksxx. Am Dienstag, den 30.09.2014, 22:18 -0400 schrieb Harlan Lieberman-Berg: > Hello Jörg! > > I took a look at psocksxx, and it looks pretty good! A couple minor > things that need to be changed: > > - The section "comm" is meant for management of

Bug#763540: Review of psocksxx/0.0.5-1

2014-09-30 Thread Harlan Lieberman-Berg
Hello Jörg! I took a look at psocksxx, and it looks pretty good! A couple minor things that need to be changed: - The section "comm" is meant for management of modems, especially ones connecting through POTS. The section for libpsockxx0 should probably be "libs". - Because there are autotools f