Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-16 Thread Sam Hartman
control: clone -1 -2 control: retitle -2 krb5-config breaks high-warning builds control: severity -2 serious I think what I'd like to do here is quickly revert moving krb5-config into krb5-multidev and revert the patch to spit out -I/usr/include/mit-kerberos. We can then work on this on a branch

Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-15 Thread Russ Allbery
Michael Tautschnig writes: >> I generally agree with you that it would be better to write >> -Wundef-clean code, but a lot of examples from, say, Autoconf are not >> -Wundef-clean, so I suspect there's a lot of this out there. And since >> behavior of an undefined variable in preprocessor direct

Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-09 Thread Michael Tautschnig
Control: severity -1 wishlist [...] > I'm not sure if you can use #ifdef with #elif. I've always avoided doing > so, but have to admit having not looked it up in the C standard. > Just for the record, here's what it says: "Preprocessing directives of the forms #ifdef identifier new-line group

Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-09 Thread Russ Allbery
Michael Tautschnig writes: >> In this specific case, it would probably be fine for the MIT Kerberos code >> base to change this line to instead be: >> >> #if !defined(TARGET_OS_MAC) > ^ (Sure? I don't think negation is due here.) Ack, you're correct. I reversed the sense. > So I

Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-09 Thread Michael Tautschnig
Control: clone 751054 -2 Control: reassign -2 pidgin-sipe 1.18.1-1 Control: severity -2 serious Control: retitle -2 pidgin-sip: FTBFS - uses -Werror -Wundef with third-party headers > Michael Tautschnig writes: > > > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -D_FORTIFY_SOURCE=2 > > -W

Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-09 Thread Russ Allbery
Michael Tautschnig writes: > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -D_FORTIFY_SOURCE=2 > -Werror -Wall -Wextra -Waggregate-return -Wcast-align > -Wdeclaration-after-statement -Wdeprecated-declarations -Winit-self > -Wmaybe-uninitialized -Wmissing-declarations -Wmissing-prototypes

Bug#751054: krb5-multidev: use #ifdef rather than #if in gssapi.h

2014-06-09 Thread Michael Tautschnig
Package: krb5-multidev Version: 1.12.1+dfsg-2 Affects: pidgin-sipe Trying to build pidgin-sipe failed with the following error: [...] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -D_FORTIFY_SOURCE=2 -Werror -Wall -Wextra -Waggregate-return -Wcast-align -Wdeclaration-after-statement -Wdepr