On 2014-03-06 08:32, Mathieu Parent wrote:
> 2014-02-22 18:42 GMT+01:00 Niels Thykier :
> [...]
>
> Hi,
>
> Thanks for your review.
>
>>>
>>> +$self->{binary_names} = ();
>>
>> I think you need to use "[]" instead of "()" here (to get a list ref)
>
> [...]
>>> +push $self->{binary_n
2014-02-22 18:42 GMT+01:00 Niels Thykier :
[...]
Hi,
Thanks for your review.
>>
>> +$self->{binary_names} = ();
>
> I think you need to use "[]" instead of "()" here (to get a list ref)
[...]
>> +push $self->{binary_names}, $pkg;
>
> Likewise, you need "push(@{$self->{binary_names}
On 2014-02-22 17:40, Mathieu Parent wrote:
> 2014-02-22 8:09 GMT+01:00 Niels Thykier :
>> >
>> > Hi,
> Hi Niels,
>
>> > The result is "unordered" because it is the result of a "keys %{...}"
>> > operation and the order of hash keys are "undefined" in Perl (between
>> > runs at least). It would be
2014-02-22 8:09 GMT+01:00 Niels Thykier :
>
> Hi,
Hi Niels,
> The result is "unordered" because it is the result of a "keys %{...}"
> operation and the order of hash keys are "undefined" in Perl (between
> runs at least). It would be simple to get a "defined" order by simply
> sorting the keys b
On 2014-02-21 07:21, Mathieu Parent wrote:
> Package: lintian
> Version: 2.5.21
>
> Hi lintian maintainers,
>
> The phppear check aims to check for special substvars in the main
> binary package, which is usually the first. it is coded like that:
>
> my $binary = $binaries[0];
>
> [ref]:
> htt
Package: lintian
Version: 2.5.21
Hi lintian maintainers,
The phppear check aims to check for special substvars in the main
binary package, which is usually the first. it is coded like that:
my $binary = $binaries[0];
[ref]:
http://anonscm.debian.org/gitweb/?p=lintian/lintian.git;a=blob;f=check
6 matches
Mail list logo
