Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-18 Thread Michael Vogt
On Mon, Mar 18, 2013 at 08:28:58AM +0100, Niels Thykier wrote: > On 2013-03-18 08:25, Michael Vogt wrote: > > On Mon, Mar 18, 2013 at 08:54:02AM +0800, Daniel Hartwig wrote: > >> On 18 March 2013 04:05, Michael Vogt wrote: > >>> This patch looks good! I commited it to bzr. Unfortunately its not >

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-18 Thread Daniel Hartwig
On 18 March 2013 15:25, Michael Vogt wrote: >> This makes it so the first failure prevents later tests in the same >> file from running. It can be bothersome to diagnose faults if e.g. >> individual tests are not properly ordered, or are otherwise >> independent of each other. Some test framewor

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-18 Thread Niels Thykier
On 2013-03-18 08:25, Michael Vogt wrote: > On Mon, Mar 18, 2013 at 08:54:02AM +0800, Daniel Hartwig wrote: >> On 18 March 2013 04:05, Michael Vogt wrote: >>> This patch looks good! I commited it to bzr. Unfortunately its not >>> sufficient as current a msgfail() in framework will not cause a != 0

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-18 Thread Michael Vogt
On Mon, Mar 18, 2013 at 08:54:02AM +0800, Daniel Hartwig wrote: > On 18 March 2013 04:05, Michael Vogt wrote: > > This patch looks good! I commited it to bzr. Unfortunately its not > > sufficient as current a msgfail() in framework will not cause a != 0 > > exit status. So to properly fix this som

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-17 Thread Daniel Hartwig
On 18 March 2013 08:54, Daniel Hartwig wrote: > On 18 March 2013 04:05, Michael Vogt wrote: >> This patch looks good! I commited it to bzr. Unfortunately its not >> sufficient as current a msgfail() in framework will not cause a != 0 >> exit status. So to properly fix this some more work is neede

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-17 Thread Daniel Hartwig
On 18 March 2013 04:05, Michael Vogt wrote: > This patch looks good! I commited it to bzr. Unfortunately its not > sufficient as current a msgfail() in framework will not cause a != 0 > exit status. So to properly fix this some more work is needed. > > The attached (additional) patch should make i

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-17 Thread Michael Vogt
On Sun, Mar 17, 2013 at 05:42:34PM +0100, Niels Thykier wrote: > Package: apt > Version: 0.9.7.8 > Severity: normal > Tags: patch Thanks for your bugreport and your patch! > Currently, the APT build process will continue even if one of the > tests in test/libapt fails. On IRC (#d-apt) we concl

Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

2013-03-17 Thread Niels Thykier
Package: apt Version: 0.9.7.8 Severity: normal Tags: patch Currently, the APT build process will continue even if one of the tests in test/libapt fails. On IRC (#d-apt) we concluded this was not the desired behaviour. I am attaching a (prototype) patch for fixing this issue. ~Niels === modifie