Bug#688728: debirf: serial-terminal module cmdline matching

2012-09-25 Thread Matt Taggart
Matt Taggart writes: > I had a machine fail to start a getty on the serial and then it worked with > a freshly built debirf with that change. But maybe it was something else > that changed. I will try to repeat the problem and report back. I can't repeat it on a different machine. What I suspect

Bug#688728: debirf: serial-terminal module cmdline matching

2012-09-25 Thread Matt Taggart
Daniel Kahn Gillmor writes: > this is within a for loop: > > for param in $(cat /proc/cmdline); do > ... > > the result that each element assigned to $param is split from the next > by IFS, which is basic whitespace. Ah I see! > hm, i don't think it does. have you verified this? the anchor

Bug#688728: debirf: serial-terminal module cmdline matching

2012-09-25 Thread Daniel Kahn Gillmor
On 09/25/2012 03:14 PM, Matt Taggart wrote: > Daniel Kahn Gillmor writes: >> do you have an example of where this actually fails to work? > > I had a machine fail to start a getty on the serial and then it worked with > a freshly built debirf with that change. But maybe it was something else > t

Bug#688728: debirf: serial-terminal module cmdline matching

2012-09-25 Thread Daniel Kahn Gillmor
Control: tags 668728 + moreinfo On 09/25/2012 01:12 AM, Matt Taggart wrote: > if printf "%s" "$param" | egrep -q '^console=ttyS[0-9]+,[0-9]+n8$'; then this is within a for loop: for param in $(cat /proc/cmdline); do ... the result that each element assigned to $param is split from the next

Bug#688728: debirf: serial-terminal module cmdline matching

2012-09-24 Thread Matt Taggart
Package: debirf Version: 0.33 In the serial-terminal module, line 21, if printf "%s" "$param" | egrep -q '^console=ttyS[0-9]+,[0-9]+n8$'; then the egrep regex to detect a serial console is anchored with ^ at the front, assuming that this console entry will be the first thing on the cmdline.