Bug#655521: chromium-browser: Source package does not build on Ubuntu

2012-01-12 Thread Michael Kuhn
Hi, > I see. Maybe the following would be sensible. Or maybe hard-code > "Debian" like /usr/bin/chromium does. > > diff --git i/debian/rules w/debian/rules > index cc4981d2..83cf7a4e 100755 > --- i/debian/rules > +++ w/debian/rules > @@ -6,7 +6,11 @@ DEBIAN_UPSTREAM_VERSION := $(shell echo

Bug#655521: chromium-browser: Source package does not build on Ubuntu

2012-01-11 Thread Michael Kuhn
Hi, > This uses /etc/debian_version so it can give the same answer as the > /usr/bin/chromium script, which uses /etc/debian_version to avoid > depending on lsb-release at runtime. > > Is this hunk needed for your patch to work? If it is just for the > about: screen, have you checked the result,

Bug#655521: chromium-browser: Source package does not build on Ubuntu

2012-01-11 Thread Jonathan Nieder
Michael Kuhn wrote: > I guess this was just to get the correct (build) output in the about > screen -- otherwise it says “Built on Ubuntu wheezy/sid”. :-) I see. Maybe the following would be sensible. Or maybe hard-code "Debian" like /usr/bin/chromium does. diff --git i/debian/rules w/debian/r

Bug#655521: chromium-browser: Source package does not build on Ubuntu

2012-01-11 Thread Jonathan Nieder
Hi, Michael Kuhn wrote: > --- chromium-browser-16.0.912.63~r113337/debian/rules 2012-01-01 > 12:46:32.0 + > +++ chromium-browser-16.0.912.63~r113337/debian/rules 2012-01-01 > 22:40:37.0 + > @@ -6,7 +6,7 @@ > DEBIAN_REVISION := $(shell echo $(DEBIAN_VERSION)

Bug#655521: chromium-browser: Source package does not build on Ubuntu

2012-01-11 Thread Michael Kuhn
Package: chromium-browser Version: 16.0.912.75~r116452-1 Severity: normal Tags: patch chromium-browser does not build from source on Ubuntu, even though debian/rules includes code to do so. The attached patch fixes the problem. -- System Information: Debian Release: wheezy/sid APT prefers one