Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-19 Thread Thorsten Glaser
Dixi quod… >Jonathan Nieder dixit: > >>Thorsten, can you test this patch or arrange for it to be tested? > >Will do that Built, WFM. bye, //mirabilos -- “Having a smoking section in a restaurant is like having a peeing section in a swimming pool.”

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Thorsten Glaser
Jonathan Nieder dixit: >There are kinder ways to say that. Thanks. >Thorsten, can you test this patch or arrange for it to be tested? Will do that once the next buildhost gets idle (one is currently building gcc-4.6 (second upload in one day), the other working its something off to build a kern

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Jonathan Nieder
Aurelien Jarno wrote: > If you are not an m68k porter, you should simply stop to care about > m68k porting issues. There are kinder ways to say that. Thorsten, can you test this patch or arrange for it to be tested? commit fb3ed187 Author: Andreas Schwab Date: Sun Mar 6 19:52:43 2011 +0100

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Andreas Schwab
Thorsten Glaser writes: > Aurelien Jarno dixit: > >>I am not an m68k porter, and I am not planning to try things. m68k is >>lagging upstream wrt other architectures. Please work with upstream to >>fix things, then I can include tested and accepted patches. > > I’m not an m68k porter either, but t

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Aurelien Jarno
On Sat, Dec 17, 2011 at 02:45:26PM +, Thorsten Glaser wrote: > Aurelien Jarno dixit: > > >If you are not an m68k porter, you should simply stop to care about > >m68k porting issues. > > I care about the entire Open Source ecosystem. (Way to motivate people.) > Then if you care, do the work

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Thorsten Glaser
Aurelien Jarno dixit: >If you are not an m68k porter, you should simply stop to care about >m68k porting issues. I care about the entire Open Source ecosystem. (Way to motivate people.) bye, //mirabilos -- 13:22⎜«neurodamage» mira, what's up man? I have a CVS question for you in #cvs 13:22⎜«ne

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Aurelien Jarno
On Sat, Dec 17, 2011 at 12:51:48PM +, Thorsten Glaser wrote: > Aurelien Jarno dixit: > > >I am not an m68k porter, and I am not planning to try things. m68k is > >lagging upstream wrt other architectures. Please work with upstream to > >fix things, then I can include tested and accepted patche

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Thorsten Glaser
Aurelien Jarno dixit: >I am not an m68k porter, and I am not planning to try things. m68k is >lagging upstream wrt other architectures. Please work with upstream to >fix things, then I can include tested and accepted patches. I’m not an m68k porter either, but this fix is easily done from working

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Aurelien Jarno
On Sat, Dec 17, 2011 at 02:52:53AM +, Thorsten Glaser wrote: > Aurelien Jarno dixit: > > >I have dropped it in favor of the default version for the next upload. > > Why don’t you just use these? (Tested for 32-bit and 64-bit both.) I am not an m68k porter, and I am not planning to try things

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-16 Thread Thorsten Glaser
Aurelien Jarno dixit: >I have dropped it in favor of the default version for the next upload. Why don’t you just use these? (Tested for 32-bit and 64-bit both.) I’ve not looked at other architectures atm though. --- usr/include/m68k-linux-gnu/bits/byteswap.h~ 2011-12-17 02:44:08.0 +

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-16 Thread Aurelien Jarno
On Fri, Dec 16, 2011 at 03:29:59PM +, Thorsten Glaser wrote: > Source: eglibc > > Hi, > > (from #595496) please make sure that this passes on all > architectures: > > cat >x.c <<'EOF' > #include > #include > #include > > uint32_t > foo(uint32_t *bar, size_t *baz) { > return (bswap_

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-16 Thread Thorsten Glaser
Source: eglibc Hi, (from #595496) please make sure that this passes on all architectures: cat >x.c <<'EOF' #include #include #include uint32_t foo(uint32_t *bar, size_t *baz) { return (bswap_32(bar[(*baz)++])); } EOF gcc -Wall -c x.c On amd64 it passes, on m68k it gives: x.c: In f