Bug#652355: git-daemon-sysvinit: requires a switch to be flipped before it works

2020-02-04 Thread Andreas Henriksson
Hello, https://lintian.debian.org/tags/init.d-script-should-always-start-service.html Please get rid of the variable in favour of using the handling described in debian policy. eg. user can override things via policy-rc.d and if you don't want to have the service started/enabled by default then

Bug#652355: git-daemon-sysvinit: requires a switch to be flipped before it works

2013-11-21 Thread Antonio Ospite
Package: git-daemon-sysvinit Followup-For: Bug #652355 Dear Maintainer, FWIW I too think that GIT_DAEMON_ENABLE=false is a good idea. So I'd leave it just as it is now. In my use case I have git repositories under /home/git/repositories, and being forced to look at /etc/default/git-daemon in ord

Bug#652355: git-daemon-sysvinit: requires a switch to be flipped before it

2012-01-06 Thread Daniel Baumann
On 01/06/2012 06:17 PM, Jonathan Nieder wrote: if a enabled=true/false flag should be kept for convenience, rather than to trigger sysvinit or even packaging changes, is your call. No, it's your call. i personally, for the interest of keeping daemon configs on the principle of

Bug#652355: git-daemon-sysvinit: requires a switch to be flipped before it

2012-01-06 Thread Jonathan Nieder
Hi Daniel, Daniel Baumann wrote: > if a enabled=true/false flag should be kept for convenience, > rather than to trigger sysvinit or even packaging changes, is your call. No, it's your call. [...] > would you accept patches to add that support (for the directory question, > and, if

Bug#652355: git-daemon-sysvinit: requires a switch to be flipped before it

2012-01-06 Thread Daniel Baumann
sorry for the late answer. first, the enable flag (and having it by default set to false is) is in general a good thing. that way, a daemon does need to get manually enabled by the admin. this appears to be specifically nice for daemons such as git-daemon which might "suddenly" expose users da

Bug#652355: git-daemon-sysvinit: requires a switch to be flipped before it works

2011-12-16 Thread Jonathan Nieder
Package: git-daemon-sysvinit Version: 1:1.7.7.3-1 Severity: wishlist Tags: patch Hi Daniel, When you submitted the /etc/init.d/git-daemon patch, I encouraged adding a GIT_DAEMON_ENABLE knob so the sysadmin can put GIT_DAEMON_ENABLE=false in /etc/default/git-daemon, then install git-daem