Hi Jelmer,
On Sep 19, 2011, at 11:22 PM, Jelmer Vernooij wrote:
>> client.c:318 client_set_notify_funct() where notify_baton2 has
>> inconsistent
>> refcounting between the if-clause and else-clause. When you go through the
>> if-clause, notify_baton2 steals a reference to Py_None, which is going
Hi Barry,
Thanks again for having a look at these. I don't think any of these are
likely to cause issues in practice, but they're still good to fix.
On Mon 19 Sep 2011 10:16:33 PM CEST, Barry Warsaw wrote:
I did a very quick review of the C code here (branched from
debianlp:subvertpy
on Laun
Hi Barry,
Thanks again for having a look at these. I don't think any of these are
likely to cause issues in practice, but they're still good to fix.
On Mon 19 Sep 2011 10:16:33 PM CEST, Barry Warsaw wrote:
I did a very quick review of the C code here (branched from
debianlp:subvertpy
on La
Hi Barry,
Thanks for the review. Can you please open a separate bug report about
these issues, either here or on Launchpad?
Thanks,
Jelmer
On 09/19/2011 10:16 PM, Barry Warsaw wrote:
I did a very quick review of the C code here (branched from debianlp:subvertpy
on Launchpad, so should be th
I did a very quick review of the C code here (branched from debianlp:subvertpy
on Launchpad, so should be the sid package), and found a number of
questionable things. I don't know the library code or the svn API very well,
so it's entirely possible that some or all of these are false alarms. It's
5 matches
Mail list logo
