Fixed version of the patch - Garo (conky developer) noticed that
temporary file is neved deleted, resulting in filling the hard drive.
Patch v2 is attached.
--
Vasiliy
commit 9370e9ffefc5decb7538585f973c717425e60957
Author: Vasiliy Kulikov
Date: Fri Feb 11 20:19:36 2011 +0300
Fixed race
Hi Brandon,
Your patch is not full. It only tries to create unique filename, but it
cannot guarantee that the file doesn't exist. The filename shouldn't be
totally unpredictable, but there must be a guarantee that the file
doesn't exists. mkstemp(3) does it. Glibc calls open(2) with perms = 0
2 matches
Mail list logo
