Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Holger Levsen
On Freitag, 1. Oktober 2010, Daniel Reichelt wrote: > Since Holger asked me to write s.th. for the README, are we talking > about an upstream default or Debian-specific? both? ;-) for a start, having debian specific notes would already be a huge improvement. there is svn://munin.projects.linp

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Tom Feiner
On Fri, Oct 1, 2010 at 7:06 PM, Daniel Reichelt wrote: > > > Good point! In that case 775 would be a more reasonable default for cgi > > > and non-cgi. > Well, in that case my patch was in vain. Might have just talked to you > guys first :) > > Since Holger asked me to write s.th. for the README,

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Daniel Reichelt
> I think 775 by default would make the default installation (non-cgi > mode) insecure. Depends. Since the htmldir is still owned by group munin, only a member of that group could go rampage on those files. IMHO the rrd files are far more valueable than the dynamically generated files within the c

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Daniel Reichelt
> > Good point! In that case 775 would be a more reasonable default for cgi > > and non-cgi. Well, in that case my patch was in vain. Might have just talked to you guys first :) Since Holger asked me to write s.th. for the README, are we talking about an upstream default or Debian-specific? --

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Tom Feiner
On Fri, Oct 1, 2010 at 6:59 PM, Daniel Reichelt wrote: > > I think 775 by default would make the default installation (non-cgi > > mode) insecure. > > Depends. Since the htmldir is still owned by group munin, only a member > of that group could go rampage on those files. IMHO the rrd files are > f

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Holger Levsen
Hi Tom, On Freitag, 1. Oktober 2010, Tom Feiner wrote: > On Fri, Oct 1, 2010 at 6:19 PM, Holger Levsen wrote: > > shouldn't the default become 775 to fix the bug you encountered? > > I think 775 by default would make the default installation (non-cgi mode) > insecure. Ah. Then we should add the

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Tom Feiner
On Fri, Oct 1, 2010 at 6:19 PM, Holger Levsen wrote: > > shouldn't the default become 775 to fix the bug you encountered? > I think 775 by default would make the default installation (non-cgi mode) insecure. Tom.

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Tom Feiner
forwarded 598737 http://munin-monitoring.org/ticket/977 quit Hi Daniel. Thanks for the bug report. This does look like an inconvenience. However, as this is an upstream issue, I've forwarded the bug upstream. Let's see what they have to say about the issue. Regards, Tom Feiner

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Holger Levsen
Hi Daniel, thanks for your bug report and patch! On Freitag, 1. Oktober 2010, Daniel Reichelt wrote: > If that line is missing, the $htmldir_mode variable will be initialized > with the former default value of 755. Additionally, the keyword > htmldir_mode is added as a legal config keyword in Com

Bug#598737: munin-cgi-graph: handle html cache dir creation more flexible

2010-10-01 Thread Daniel Reichelt
Package: munin Version: 1.4.5-2 Severity: normal Tags: upstream patch Hi, I just stumbled over the following nasty inconvenience: - cgi-graphing enabled - www-data is member of group munin, so for cgi graphing to work the cache dirs need to be group writeable - added new node to be monitored -