Bug#581122: mercurial-common: bashism in /bin/sh script

2010-05-12 Thread Raphael Geissert
Hi, On Tuesday 11 May 2010 03:44:19 Javi Merino wrote: > Hi, I think the attached patch fixes the bashism by creating a function > that returns a random number instead of relying on the $RANDOM magic > variable. > Thanks for working on fixing it so fast. About the patch: using mktemp(1) would b

Bug#581122: mercurial-common: bashism in /bin/sh script

2010-05-11 Thread Vincent Danjean
On 11/05/2010 11:40, Javi Merino wrote: > On 11/05/10 11:12, Thomas Arendsen Hein wrote: [useful things about this bug] Sorry, I just see your mails, after the upload of mercurial 1.5.2-1 where I solved this bug by changing the shebang line. bash being essential in Debian, I will not diverge more

Bug#581122: mercurial-common: bashism in /bin/sh script

2010-05-11 Thread Javi Merino
On 11/05/10 11:12, Thomas Arendsen Hein wrote: > * Javi Merino [20100511 10:48]: >> Hi, I think the attached patch fixes the bashism by creating a function >> that returns a random number instead of relying on the $RANDOM magic >> variable. >> >> I'll try to get it accepted upstream. > > I'm not

Bug#581122: mercurial-common: bashism in /bin/sh script

2010-05-11 Thread Thomas Arendsen Hein
* Javi Merino [20100511 10:48]: > Hi, I think the attached patch fixes the bashism by creating a function > that returns a random number instead of relying on the $RANDOM magic > variable. > > I'll try to get it accepted upstream. I'm not sure if something based on /dev/urandom will be accepted

Bug#581122: mercurial-common: bashism in /bin/sh script

2010-05-11 Thread Javi Merino
Hi, I think the attached patch fixes the bashism by creating a function that returns a random number instead of relying on the $RANDOM magic variable. I'll try to get it accepted upstream. Regards, Javi (Vicho) On 11/05/10 07:42, Raphael Geissert wrote: > Package: mercurial-common > Severity: mi